You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2019/04/24 18:13:20 UTC
[Impala-ASF-CR] IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13103
Change subject: IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
......................................................................
IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
Currently the test_mem_limit in TestAdmissionControllerStress ecounters
flaky failures due to a timeout waiting on queries to end. Increasing
the timeout from 60 to 90 seconds to accommodate this flakiness.
Testing:
Ran the test in a loop for more than 15 hours without any failures.
Change-Id: If9ada7bdbe2461d164100badabb905cf9a8cf4cc
---
M tests/custom_cluster/test_admission_controller.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/13103/1
--
To view, visit http://gerrit.cloudera.org:8080/13103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If9ada7bdbe2461d164100badabb905cf9a8cf4cc
Gerrit-Change-Number: 13103
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
[Impala-ASF-CR] IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13103 )
Change subject: IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/13103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9ada7bdbe2461d164100badabb905cf9a8cf4cc
Gerrit-Change-Number: 13103
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Apr 2019 18:39:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13103 )
Change subject: IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9ada7bdbe2461d164100badabb905cf9a8cf4cc
Gerrit-Change-Number: 13103
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 00:05:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13103 )
Change subject: IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4058/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9ada7bdbe2461d164100badabb905cf9a8cf4cc
Gerrit-Change-Number: 13103
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Apr 2019 19:05:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13103 )
Change subject: IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9ada7bdbe2461d164100badabb905cf9a8cf4cc
Gerrit-Change-Number: 13103
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Apr 2019 19:05:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13103 )
Change subject: IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2887/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9ada7bdbe2461d164100badabb905cf9a8cf4cc
Gerrit-Change-Number: 13103
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Apr 2019 18:55:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13103 )
Change subject: IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
......................................................................
IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
Currently the test_mem_limit in TestAdmissionControllerStress encounters
flaky failures due to a timeout waiting on queries to end. Increasing
the timeout from 60 to 90 seconds to accommodate this flakiness.
Testing:
Ran the test in a loop for more than 15 hours without any failures.
Change-Id: If9ada7bdbe2461d164100badabb905cf9a8cf4cc
Reviewed-on: http://gerrit.cloudera.org:8080/13103
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_admission_controller.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If9ada7bdbe2461d164100badabb905cf9a8cf4cc
Gerrit-Change-Number: 13103
Gerrit-PatchSet: 4
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13103 )
Change subject: IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13103/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13103/1//COMMIT_MSG@9
PS1, Line 9: ecounters
encounters
--
To view, visit http://gerrit.cloudera.org:8080/13103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9ada7bdbe2461d164100badabb905cf9a8cf4cc
Gerrit-Change-Number: 13103
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Apr 2019 18:32:12 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13103 )
Change subject: IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9ada7bdbe2461d164100badabb905cf9a8cf4cc
Gerrit-Change-Number: 13103
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Apr 2019 19:01:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13103 )
Change subject: IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
......................................................................
Patch Set 2:
(1 comment)
Carrying over Tim's +1
http://gerrit.cloudera.org:8080/#/c/13103/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13103/1//COMMIT_MSG@9
PS1, Line 9: encounter
> encounters
Done
--
To view, visit http://gerrit.cloudera.org:8080/13103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9ada7bdbe2461d164100badabb905cf9a8cf4cc
Gerrit-Change-Number: 13103
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Apr 2019 18:55:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13103
to look at the new patch set (#2).
Change subject: IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
......................................................................
IMPALA-8295: Fix flakiness in TestAdmissionControllerStress
Currently the test_mem_limit in TestAdmissionControllerStress encounters
flaky failures due to a timeout waiting on queries to end. Increasing
the timeout from 60 to 90 seconds to accommodate this flakiness.
Testing:
Ran the test in a loop for more than 15 hours without any failures.
Change-Id: If9ada7bdbe2461d164100badabb905cf9a8cf4cc
---
M tests/custom_cluster/test_admission_controller.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/13103/2
--
To view, visit http://gerrit.cloudera.org:8080/13103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If9ada7bdbe2461d164100badabb905cf9a8cf4cc
Gerrit-Change-Number: 13103
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>