You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/03/01 21:31:43 UTC
[GitHub] gianm commented on a change in pull request #7176: Fix two
SeekableStream serde issues.
gianm commented on a change in pull request #7176: Fix two SeekableStream serde issues.
URL: https://github.com/apache/incubator-druid/pull/7176#discussion_r261764622
##########
File path: extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaIndexTaskModule.java
##########
@@ -44,6 +44,7 @@
new NamedType(KafkaIndexTask.class, "index_kafka"),
new NamedType(KafkaDataSourceMetadata.class, "kafka"),
new NamedType(KafkaIndexTaskIOConfig.class, "kafka"),
+ new NamedType(KafkaIndexTaskTuningConfig.class, "KafkaTuningConfig"),
Review comment:
Sadly, it needs to be this way for backwards compatibility (the old code didn't have a type name specified, so it used `KafkaTuningConfig`, and we want to be able to read old stuff).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org