[GitHub] [maven-site] elharo commented on a change in pull request #240: Use an SPDX identifier in example, as recommended

[GitBox <gi...@apache.org>]

elharo commented on a change in pull request #240:
URL: https://github.com/apache/maven-site/pull/240#discussion_r662193689



##########
File path: content/apt/pom.apt
##########
@@ -1474,10 +1474,10 @@ Display parameters as parsed by Maven (in canonical form) and comparison result:
 +-------------------------+
 <licenses>
   <license>
-    <name>Apache License, Version 2.0</name>
+    <name>Apache-2.0</name>
     <url>https://www.apache.org/licenses/LICENSE-2.0.txt</url>
     <distribution>repo</distribution>
-    <comments>A business-friendly OSS license</comments>
+    <comments>Apache License, Version 2.0 - A business-friendly OSS license</comments>

Review comment:
       typography nit: you want an em dash — after 2.0, not a hyphen
   
   also probably make "A" lower case since it no longer starts the sentence and change "OSS" to "open source"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org