[GitHub] [incubator-pinot] chenboat commented on issue #4608: Unit tests and bug fixes for DeleteTable rest API for controller.

[GitBox <gi...@apache.org>]

chenboat commented on issue #4608: Unit tests and bug fixes for DeleteTable rest API for controller.
URL: https://github.com/apache/incubator-pinot/pull/4608#issuecomment-531331597
 
 
   > Is this somehow causing an issue in your environment? What is the motivation behind this change?
   
   Yes. We are running on ~April 2019 version of Pinot (0.1.0).The delete table REST API then is buggy and very confusing: when I did "curl control_url/tables/A_REALTIME", the returned response is 
   _{"status":"Table deleted [A_REALTIME_OFFLINE, A_REALTIME]"}._ It was really scary for the first sight because it seemed to delete the offline table as well (actually upon very careful examination) it is fine. 
   
   The delete table API is very important (probably more important than create) because it can remove data. Furthermore, Pinot has this offline and realtime sub-table concepts and make the logic not straightforward. The bug fix since April on this API fixed the above issue. But I still believe there is room to improve:
   
   1. No UNIT test coverage for such an important API -- this is actually the main goal of this PR.
   2. The double negative boolean checks in the current codes are not very readable -- I think at least for now we should abstract them out as methods.
   3. The minor issue on non-existent tables -- this issue also justifies we should at test coverage on the method.
      

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org