Re: [healthcheck] Equivalent of SystemReady service?

[Robert Munteanu <ro...@apache.org>]

Hi Georg,

On Mon, 2020-06-29 at 17:57 +0200, Georg Henzler wrote:
> Hi Robert,
> 
> 
> 
> sorry for the delay, but now I'm back on to this and after polishing,
> 
> I'm planning to release everything within the next two weeks.

That would be great, thanks!

> 
> > 4. I was also surprised that I needed to create an executor for the
> > 'Healthy' event to be registered. I thought that with the
> > eventadmin
> > requirement the services would be registered automatically, without
> > me
> > intervening.
> 
> 
> So no instance of HealthCheckMonitor is active by default currently.
> 
> Configuring one means that the tags as given will be regularly
> 
> executed. To be exactly in line with systemready, you would configure
> 
> an instance of HealthCheckMonitor with tag "systemready" and
> 
> intervalInSec=5. Would you have expected that this config is done
> 
> automatically for the case the event admin is present? (we
> 
> definitely cannot start monitors for all checks by default, that
> 
> would potentially be harmful)

Hm, so by definition no checks are executed, even though they are
defined? Then probably it does not make sense to execute some of them
by default. I though that they would be executed by default once
registered.
> 
> 
> 
> > 3. I was a bit surprised that hc.core requires the Servlet API. The
> > systemready bundle was a bit more lightweight.
> 
> 
> systemready had the same dependency, just optional. I created
> 
> FELIX-6289 to make it also optional for hc.core.

Great, thanks,

> 
> 
> 
> > 2. core build fails with pax-exam tests. Perhaps related to Java
> > 11?
> 
> 
> I checked this, it is indeed a Java 11 problem (just checked both
> 
> 1.8 and 11). I'll check and fix.

Ack.

> 
> 
> 
> > 1. api build fails due to the baselining check
> 
> 
> this I could not reproduce.

It only happens on Java 11, and it looks like a false positive.

[INFO] -----------------------------------------------------------------------------------------------------------
[INFO] * org.apache.felix.hc.api.execution                  changed    2.0.0      2.0.0      2.0.1      Version increase required
[INFO]      ~ class org.apache.felix.hc.api.execution.HealthCheckSelector
[INFO]          ~ method hashCode()
[INFO]              - annotated jdk.internal.HotSpotIntrinsicCandidate
[INFO] -----------------------------------------------------------------------------------------------------------
[ERROR] org.apache.felix.hc.api.execution: Version increase required; detected 2.0.0, suggested 2.0.1

Not sure if there is anything to be done here. See also 
https://github.com/bndtools/bnd/issues/2177 for context.

Thanks,
Robert