[GitHub] [arrow] westonpace commented on issue #35507: [C++] Refactor debug-logging facilities in `AsofJoinNode`

["westonpace (via GitHub)" <gi...@apache.org>]

westonpace commented on issue #35507:
URL: https://github.com/apache/arrow/issues/35507#issuecomment-1540609371

   Following up on your question about number 5.
   
   You asked:
   
   > Does GLOG allow collecting log messages in a buffer, so that the program could decide either to reset the buffer or flush it to the output stream? This is the main feature I needed here to avoid getting an enormous amount of debug-log messages due to the many successful test iterations that aren't relevant to the repro.
   
   Glog can't do this out of the box.  However, you can create a custom sink that could do this.  We could register the custom sink (using a test environment) with googletest so it only spit out the logs if a test fails.
   
   Docs on custom sinks: https://github.com/google/glog/blob/b70ea80433c2a8f20b832be97b90f1f82b0d29e9/src/glog/logging.h.in#L1750-L1795
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org