You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by static-max <gi...@git.apache.org> on 2016/09/30 21:07:52 UTC
[GitHub] flink pull request #2579: [FLINK-4618] FlinkKafkaConsumer09 should start fro...
GitHub user static-max opened a pull request:
https://github.com/apache/flink/pull/2579
[FLINK-4618] FlinkKafkaConsumer09 should start from the next record on startup from offsets in Kafka
This PR addresses https://issues.apache.org/jira/browse/FLINK-4618, which causes the last message to be read again from Kafka after a fresh start of the job.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/static-max/flink flink-connector-kafka-0.9-fix-duplicate-messages
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2579.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2579
----
commit 0b564203cdae3b21b00bb499b85feb799136e29b
Author: static-max <ma...@live.de>
Date: 2016-09-30T19:45:38Z
Merge pull request #1 from apache/master
Pull from origin
commit 3618f5053e0ffb0ec1f789c56d878ed400e27056
Author: Max Kuklinski <ma...@live.de>
Date: 2016-09-30T21:03:30Z
FLINK-4618 Incremented the commited offset by one to avoid duplicate read message.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2579: [FLINK-4618] FlinkKafkaConsumer09 should start from the n...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2579
Thank you for working on this @static-max! Changes look good, will merge this.
I'll also add an IT test when merging to ensure that the Kafka consumer is starting at the right place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2579: [FLINK-4618] FlinkKafkaConsumer09 should start from the n...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2579
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2579: [FLINK-4618] FlinkKafkaConsumer09 should start fro...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2579
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2579: [FLINK-4618] FlinkKafkaConsumer09 should start from the n...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2579
Btw, just a small tip: the Flink community usually use git rebase on the current master before submitting PRs to reduce the unnecessary merge commit ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---