You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Kenneth Knowles (Jira)" <ji...@apache.org> on 2021/05/15 17:58:02 UTC

[jira] [Updated] (BEAM-10479) UDF / UDAF support for ZetaSQLQueryPlanner

     [ https://issues.apache.org/jira/browse/BEAM-10479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kenneth Knowles updated BEAM-10479:
-----------------------------------
    Resolution: Fixed
        Status: Resolved  (was: Resolved)

Hello! Due to a bug in our Jira configuration, this issue had status:Resolved but resolution:Unresolved.

I am bulk editing these issues to have resolution:Fixed

If a different resolution is appropriate, please change it. To do this, click the "Resolve" button (you can do this even for closed issues) and set the Resolution field to the right value.

> UDF / UDAF support for ZetaSQLQueryPlanner
> ------------------------------------------
>
>                 Key: BEAM-10479
>                 URL: https://issues.apache.org/jira/browse/BEAM-10479
>             Project: Beam
>          Issue Type: New Feature
>          Components: dsl-sql-zetasql
>            Reporter: Jacob Ferriero
>            Priority: P3
>
> [BeamSqlDslUdfUdafTest | https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslUdfUdafTest.java] should be refactored so each test runs against all supported Query Planners (namely Calcite and Zeta SQL).
> This could be achieved without code duplication by using Parameterized tests and having each test run with both query planners (and easily support adding more QueryPlanners in the future if necessary).
> {code:java}
> import org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLQueryPlanner;
> import org.apache.beam.sdk.extensions.sql.impl.CalciteQueryPlanner;
> @RunWith(Parameterized.class)
> public class BeamSqlDslUdfUdafTest extends BeamSqlDslBase {
>    public QueryPlanner planner;
>   @Parameters(name = "{0}")
>   public static Collection<Class<? extends QueryPlanner>> planners(){
>     return Arrays.asList(
>       CalciteQueryPlanner.class,
>       ZetaSQLQueryPlanner.class)
>   }
>   BeamSqlDslUdfUdafTest(Class<? extends QueryPlanner> planner){
>     this.planner = planner;
>   }
>   // TODO refactor each test that run SqlTransform::query to use SqlTransform::withQueryPlannerClass(this.planner)
>   ...
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)