You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/06/17 06:14:04 UTC
[GitHub] [hbase] WenFeiYi opened a new pull request #1914: HBASE-24550 Passing '-h' or '--help' to bin/hbase doesn't do as expected
WenFeiYi opened a new pull request #1914:
URL: https://github.com/apache/hbase/pull/1914
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #1914: HBASE-24550 Passing '-h' or '--help' to bin/hbase doesn't do as expected
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1914:
URL: https://github.com/apache/hbase/pull/1914#discussion_r442079714
##########
File path: bin/hbase-config.sh
##########
@@ -94,6 +94,10 @@ do
shift
# shellcheck disable=SC2034
DEBUG="true"
+ elif [ "--help" = "$1" ] || [ "-h" = "$1" ]
+ then
+ echo "Error usage! You should use it like 'hbase --help' or 'hbase -h'";
Review comment:
Got it, yeah user should not provide `--help` with `--config` or any other argument. This error handling is definitely helpful. Thanks @WenFeiYi .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] WenFeiYi commented on a change in pull request #1914: HBASE-24550 Passing '-h' or '--help' to bin/hbase doesn't do as expected
Posted by GitBox <gi...@apache.org>.
WenFeiYi commented on a change in pull request #1914:
URL: https://github.com/apache/hbase/pull/1914#discussion_r441928940
##########
File path: bin/hbase-config.sh
##########
@@ -94,6 +94,10 @@ do
shift
# shellcheck disable=SC2034
DEBUG="true"
+ elif [ "--help" = "$1" ] || [ "-h" = "$1" ]
+ then
+ echo "Error usage! You should use it like 'hbase --help' or 'hbase -h'";
Review comment:
bin/hbase --config ./conf/ --help version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1914: HBASE-24550 Passing '-h' or '--help' to bin/hbase doesn't do as expected
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1914:
URL: https://github.com/apache/hbase/pull/1914#issuecomment-645178214
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1914: HBASE-24550 Passing '-h' or '--help' to bin/hbase doesn't do as expected
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1914:
URL: https://github.com/apache/hbase/pull/1914#issuecomment-645179904
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 9m 12s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
| -0 :warning: | shellcheck | 0m 2s | The patch generated 1 new + 33 unchanged - 1 fixed = 34 total (was 34) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. |
| | | 10m 42s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1914/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1914 |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux cfdd57b6db77 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 510aad3125 |
| shellcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1914/1/artifact/yetus-general-check/output/diff-patch-shellcheck.txt |
| Max. process+thread count | 44 (vs. ulimit of 12500) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1914/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] WenFeiYi commented on a change in pull request #1914: HBASE-24550 Passing '-h' or '--help' to bin/hbase doesn't do as expected
Posted by GitBox <gi...@apache.org>.
WenFeiYi commented on a change in pull request #1914:
URL: https://github.com/apache/hbase/pull/1914#discussion_r441929778
##########
File path: bin/hbase-config.sh
##########
@@ -94,6 +94,10 @@ do
shift
# shellcheck disable=SC2034
DEBUG="true"
+ elif [ "--help" = "$1" ] || [ "-h" = "$1" ]
+ then
+ echo "Error usage! You should use it like 'hbase --help' or 'hbase -h'";
Review comment:
hbase will call hbase-config, and pass the parameters
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #1914: HBASE-24550 Passing '-h' or '--help' to bin/hbase doesn't do as expected
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1914:
URL: https://github.com/apache/hbase/pull/1914#discussion_r441445098
##########
File path: bin/hbase-config.sh
##########
@@ -94,6 +94,10 @@ do
shift
# shellcheck disable=SC2034
DEBUG="true"
+ elif [ "--help" = "$1" ] || [ "-h" = "$1" ]
+ then
+ echo "Error usage! You should use it like 'hbase --help' or 'hbase -h'";
Review comment:
Can you please provide an example of what exact command will bring the control here?
Is it `bin/hbase-config.sh --help` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani closed pull request #1914: HBASE-24550 Passing '-h' or '--help' to bin/hbase doesn't do as expected
Posted by GitBox <gi...@apache.org>.
virajjasani closed pull request #1914:
URL: https://github.com/apache/hbase/pull/1914
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org