Re: svn commit: r922392 - in /httpd/httpd/trunk/server/mpm: event/event.c prefork/prefork.c worker/worker.c

[Jeff Trawick <tr...@gmail.com>]

On Fri, Mar 12, 2010 at 1:49 PM,  <co...@apache.org> wrote:
> Author: covener
> Date: Fri Mar 12 18:49:26 2010
> New Revision: 922392
>
> URL: http://svn.apache.org/viewvc?rev=922392&view=rev
> Log:
> reduce the warning level in the bindprocessor() call used to make sure child
> processes aren't bound to the CPU the parent is running on.
>
> In recent levels of AIX, the parent isn't implicitly bound to a CPU
> (so the children don't inherit it), and when the AIX WPAR feature is enabled
> this call can return EPERM, even though the child process is already unbound.
>
>
> Modified:
>    httpd/httpd/trunk/server/mpm/event/event.c
>    httpd/httpd/trunk/server/mpm/prefork/prefork.c
>    httpd/httpd/trunk/server/mpm/worker/worker.c
>
> Modified: httpd/httpd/trunk/server/mpm/event/event.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/mpm/event/event.c?rev=922392&r1=922391&r2=922392&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/server/mpm/event/event.c (original)
> +++ httpd/httpd/trunk/server/mpm/event/event.c Fri Mar 12 18:49:26 2010
> @@ -1861,7 +1861,7 @@ static int make_child(server_rec * s, in
>         int status = bindprocessor(BINDPROCESS, (int) getpid(),
>                                    PROCESSOR_CLASS_ANY);
>         if (status != OK)
> -            ap_log_error(APLOG_MARK, APLOG_WARNING, errno,
> +            ap_log_error(APLOG_MARK, APLOG_DEBUG, errno,
>                          ap_server_conf,
>                          "processor unbind failed %d", status);

I presume that you've just looked at many such messages.  Can you
confirm that the logging of status can be eliminated because it is
always -1?

"Return Values

On successful completion, the bindprocessor subroutine returns 0.
Otherwise, a value of -1 is returned, and the errno global variable is
set to indicate the error."

Re: svn commit: r922392 - in /httpd/httpd/trunk/server/mpm: event/event.c prefork/prefork.c worker/worker.c

[Eric Covener <co...@gmail.com>]

On Fri, Mar 12, 2010 at 2:01 PM, Jeff Trawick <tr...@gmail.com> wrote:

> I presume that you've just looked at many such messages.  Can you
> confirm that the logging of status can be eliminated because it is
> always -1?
>
> "Return Values
>
> On successful completion, the bindprocessor subroutine returns 0.
> Otherwise, a value of -1 is returned, and the errno global variable is
> set to indicate the error."

Yes, while the doc doesn't reflect the interaction with the WPAR
stuff, failures due to this WPAR are still just rv of -1 and errno.

I'll drop the status as well.

-- 
Eric Covener
covener@gmail.com