You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jbonofre (via GitHub)" <gi...@apache.org> on 2024/04/13 05:23:27 UTC
[PR] Add stale PRs management [iceberg]
jbonofre opened a new pull request, #10134:
URL: https://github.com/apache/iceberg/pull/10134
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add stale PRs management [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#issuecomment-2074275369
> Does the same apply when you push to a branch but don't comment on it?
Yes, as per [doc](https://github.com/actions/stale?tab=readme-ov-file#days-before-stale)
> The issues or the pull requests will be marked as stale if the last update (based on GitHub issue field updated_at) is older than the idle number of days.
It means that any updates made, or any comments added to the issues or to the pull requests will restart the counter of days before marking as stale.
@jbonofre Are you still working on this? A gentle reminder not to forget updating `operations-per-run`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add stale PRs management [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#discussion_r1564459557
##########
.github/workflows/stale.yml:
##########
@@ -47,5 +46,13 @@ jobs:
close-issue-message: >
This issue has been closed because it has not received any activity in the last 14 days
since being marked as 'stale'
+ # stale PRs
+ stale-pr-label: 'stale'
+ exempt-pr-labels: 'not-stale,security'
+ stale-pr-message: 'This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.'
+ close-pr-message: 'This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.'
+ stale-pr-label: 'stale'
+ days-before-pr-stale: 30
+ days-before-pr-close: 7
ascending: true
- operations-per-run: 100
+ operations-per-run: 1000
Review Comment:
Looks like they suggest numbers as high of 1000 for debugging: https://github.com/actions/stale?tab=readme-ov-file#operations-per-run
I believe 100 is already quite substantial and will generate a lot of noise. Raising this to 1k might flood people's mailboxes. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add stale PRs management [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#discussion_r1563814052
##########
.github/workflows/stale.yml:
##########
@@ -47,5 +46,13 @@ jobs:
close-issue-message: >
This issue has been closed because it has not received any activity in the last 14 days
since being marked as 'stale'
+ # stale PRs
+ stale-pr-label: 'stale'
+ exempt-pr-labels: 'not-stale,security'
+ stale-pr-message: 'This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.'
Review Comment:
Spark for example uses the following message: `We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!`
I think we might also want to add some wording that makes it clear that the PR is marked as stale not because of the quality of the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add stale PRs management [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#issuecomment-2074889892
Sorry, I missed Fokko's comment. I'm ok with either way to clean up backlog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add stale PRs management [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#discussion_r1564461947
##########
.github/workflows/stale.yml:
##########
@@ -47,5 +46,13 @@ jobs:
close-issue-message: >
This issue has been closed because it has not received any activity in the last 14 days
since being marked as 'stale'
+ # stale PRs
+ stale-pr-label: 'stale'
+ exempt-pr-labels: 'not-stale,security'
+ stale-pr-message: 'This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.'
+ close-pr-message: 'This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.'
+ stale-pr-label: 'stale'
+ days-before-pr-stale: 30
+ days-before-pr-close: 7
ascending: true
- operations-per-run: 100
+ operations-per-run: 1000
Review Comment:
I set 1000 here for debugging first (to be back on 100 later). I think 100 is decent number (it's the same of the batch, it won't "limit" the issues/PRs considered to 100 actually). Let me back to 100 (debugging is probably not required if it works fine :)).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add stale PRs management [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#discussion_r1564467550
##########
.github/workflows/stale.yml:
##########
@@ -47,5 +46,13 @@ jobs:
close-issue-message: >
This issue has been closed because it has not received any activity in the last 14 days
since being marked as 'stale'
+ # stale PRs
+ stale-pr-label: 'stale'
+ exempt-pr-labels: 'not-stale,security'
+ stale-pr-message: 'This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.'
+ close-pr-message: 'This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.'
+ stale-pr-label: 'stale'
+ days-before-pr-stale: 30
+ days-before-pr-close: 7
ascending: true
- operations-per-run: 100
+ operations-per-run: 1000
Review Comment:
My original intention was to do a first run with 1000 and then back to 100 to do a first pass on PR that should be closed. But we can also do this first pass "manually".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add stale PRs management [iceberg]
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on code in PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#discussion_r1565022616
##########
.github/workflows/stale.yml:
##########
@@ -33,12 +33,11 @@ jobs:
steps:
- uses: actions/stale@v9.0.0
with:
+ # stale issues
Review Comment:
nit: Can we change the line 20 (the task name) to "Close Stale Issues and PRs" ?
##########
.github/workflows/stale.yml:
##########
@@ -47,5 +46,13 @@ jobs:
close-issue-message: >
This issue has been closed because it has not received any activity in the last 14 days
since being marked as 'stale'
+ # stale PRs
+ stale-pr-label: 'stale'
+ exempt-pr-labels: 'not-stale,security'
+ stale-pr-message: 'This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.'
+ close-pr-message: 'This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.'
+ stale-pr-label: 'stale'
Review Comment:
duplicate of line 50?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add stale PRs management [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#issuecomment-2056923294
> > overall this LGTM, but I'm a bit unsure about the 30 days. If pushing to the branch or commenting on the PR automatically counts as `activity`, then 30 days are probably ok
>
> Yes, as soon we have a new comment in a PR, the "counter" restart from zero. It means that we will have the stale flag only if we don't have any comment/activity on the PR since more than 30 days.
The commenting was clear to me. Does the same apply when you push to a branch but don't comment on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add stale PRs management [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#discussion_r1564463520
##########
.github/workflows/stale.yml:
##########
@@ -47,5 +46,13 @@ jobs:
close-issue-message: >
This issue has been closed because it has not received any activity in the last 14 days
since being marked as 'stale'
+ # stale PRs
+ stale-pr-label: 'stale'
+ exempt-pr-labels: 'not-stale,security'
+ stale-pr-message: 'This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.'
+ close-pr-message: 'This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.'
+ stale-pr-label: 'stale'
+ days-before-pr-stale: 30
+ days-before-pr-close: 7
ascending: true
- operations-per-run: 100
+ operations-per-run: 1000
Review Comment:
I saw @manuzhang's comment after I went over this. Maybe we should do some manual backlog cleaning. For example, close PRs of Spark/Flink versions that are not supported anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add stale PRs management [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#issuecomment-2053669260
@jbonofre Can you also increase `operations-per-run` to maybe 1000 or higher? With the current `100`, we are still processing stale issues in April, 2021, and it will become even slower when checking stale PRs as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add stale PRs management [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#discussion_r1563812475
##########
.github/workflows/stale.yml:
##########
@@ -47,5 +46,13 @@ jobs:
close-issue-message: >
This issue has been closed because it has not received any activity in the last 14 days
since being marked as 'stale'
+ # stale PRs
+ stale-pr-label: 'stale'
+ exempt-pr-labels: 'not-stale,security'
+ stale-pr-message: 'This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.'
+ close-pr-message: 'This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.'
+ stale-pr-label: 'stale'
+ days-before-pr-stale: 30
Review Comment:
my gut feeling tells me this should probably be a bit higher (something around 90+ days)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add stale PRs management [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#issuecomment-2085151465
@nastra @Fokko are we good to merge this one ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add stale PRs management [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#discussion_r1564079903
##########
.github/workflows/stale.yml:
##########
@@ -47,5 +46,13 @@ jobs:
close-issue-message: >
This issue has been closed because it has not received any activity in the last 14 days
since being marked as 'stale'
+ # stale PRs
+ stale-pr-label: 'stale'
+ exempt-pr-labels: 'not-stale,security'
+ stale-pr-message: 'This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.'
+ close-pr-message: 'This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.'
+ stale-pr-label: 'stale'
+ days-before-pr-stale: 30
Review Comment:
I think 30 days is reasonable as a good reminder for author and reviewers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add stale PRs management [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#issuecomment-2053708559
@manuzhang sure ! Let me update accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add stale PRs management [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#discussion_r1563845762
##########
.github/workflows/stale.yml:
##########
@@ -47,5 +46,13 @@ jobs:
close-issue-message: >
This issue has been closed because it has not received any activity in the last 14 days
since being marked as 'stale'
+ # stale PRs
+ stale-pr-label: 'stale'
+ exempt-pr-labels: 'not-stale,security'
+ stale-pr-message: 'This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.'
Review Comment:
Good idea. Let me update the comment. Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add stale PRs management [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#issuecomment-2074521876
Yup. I reverted my change due to Fokko's comment. But I can change it back and adapt once merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add stale PRs management [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#issuecomment-2085449951
@jbonofre Yes, thanks everyone for chiming in for the review 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add stale PRs management [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #10134:
URL: https://github.com/apache/iceberg/pull/10134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add stale PRs management [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#issuecomment-2056799795
> overall this LGTM, but I'm a bit unsure about the 30 days. If pushing to the branch or commenting on the PR automatically counts as `activity`, then 30 days are probably ok
Yes, as soon we have a new comment in a PR, the "counter" restart from zero. It means that we will have the stale flag only if we don't have any comment/activity on the PR since more than 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add stale PRs management [iceberg]
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #10134:
URL: https://github.com/apache/iceberg/pull/10134#issuecomment-2230381839
Looks like this never worked. This should fix it: https://github.com/apache/iceberg/pull/10706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org