[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38441: [SPARK-40979][CORE] Keep removed executor info due to decommission

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on code in PR #38441:
URL: https://github.com/apache/spark/pull/38441#discussion_r1024238330


##########
core/src/main/scala/org/apache/spark/internal/config/package.scala:
##########
@@ -2229,6 +2229,16 @@ package object config {
       .booleanConf
       .createWithDefault(false)
 
+  private[spark] val SCHEDULER_MAX_RETAINED_REMOVED_EXECUTORS =
+    ConfigBuilder("spark.scheduler.maxRetainedRemovedDecommissionExecutors")
+      .internal()
+      .doc("Max number of removed executors by decommission to retain. This affects " +
+        "whether fetch failure caused by removed decommissioned executors could be ignored " +
+        s"when ${STAGE_IGNORE_DECOMMISSION_FETCH_FAILURE.key} is enabled.")
+      .version("3.4.0")
+      .intConf

Review Comment:
   Could you add the following?
   ```
   .checkValue(_ >= 0, "needs to be a non-negative value")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org