You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/12/04 20:51:07 UTC
[GitHub] anirudh2290 commented on a change in pull request #13062:
[MXNET-1110] Add header files required by horovod
anirudh2290 commented on a change in pull request #13062: [MXNET-1110] Add header files required by horovod
URL: https://github.com/apache/incubator-mxnet/pull/13062#discussion_r238832836
##########
File path: ci/build_windows.py
##########
@@ -160,9 +160,9 @@ def windows_package(args):
copy_tree('python', j(pkgdir, 'python'))
logging.info('packing headers')
copy_tree('include', j(pkgdir, 'include'))
- copy_tree(j('3rdparty','dmlc-core','include'), j(pkgdir, 'include'))
- copy_tree(j('3rdparty','mshadow', 'mshadow'), j(pkgdir, 'include', 'mshadow'))
- copy_tree(j('3rdparty','tvm','nnvm', 'include'), j(pkgdir,'include', 'nnvm', 'include'))
+ #copy_tree(j('3rdparty','dmlc-core','include'), j(pkgdir, 'include'))
+ #copy_tree(j('3rdparty','mshadow', 'mshadow'), j(pkgdir, 'include', 'mshadow'))
+ #copy_tree(j('3rdparty','tvm','nnvm', 'include'), j(pkgdir,'include', 'nnvm', 'include'))
Review comment:
can we remove the commented lines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services