You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/03/07 15:00:11 UTC
[GitHub] [echarts] susiwen8 opened a new pull request #14417: Fix(sankey): sankey label has higher z2
susiwen8 opened a new pull request #14417:
URL: https://github.com/apache/echarts/pull/14417
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Set `sankey label` z2 property.
### Fixed issues
Close #14287
## Details
### Before: What was the problem?
<img width="110" alt="Screen Shot 2021-03-07 at 22 56 11" src="https://user-images.githubusercontent.com/20318608/110244135-57385c00-7f98-11eb-91e3-81cb30ab680e.png">
### After: How is it fixed in this PR?
<img width="192" alt="Screen Shot 2021-03-07 at 22 55 57" src="https://user-images.githubusercontent.com/20318608/110244142-5dc6d380-7f98-11eb-86dd-271e8556a7b5.png">
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
`sankey-vertical.html`
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on a change in pull request #14417: Fix(sankey): sankey label has higher z2
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #14417:
URL: https://github.com/apache/echarts/pull/14417#discussion_r610620369
##########
File path: src/chart/sankey/SankeyView.ts
##########
@@ -250,7 +250,8 @@ class SankeyView extends ChartView {
width: layout.dx,
height: layout.dy
},
- style: itemModel.getModel('itemStyle').getItemStyle()
+ style: itemModel.getModel('itemStyle').getItemStyle(),
+ z2: 10
Review comment:
@pissang @susiwen8 Sorry here. I ever reverted it in #14542. But for now, this change seems to be still needed or there is something extra to do like https://github.com/apache/echarts/pull/14542/commits/ab5838eb864d2f95f1fb3d3c7b5d5b60acc109a0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang merged pull request #14417: Fix(sankey): sankey label has higher z2
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #14417:
URL: https://github.com/apache/echarts/pull/14417
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on a change in pull request #14417: Fix(sankey): sankey label has higher z2
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #14417:
URL: https://github.com/apache/echarts/pull/14417#discussion_r610733225
##########
File path: src/chart/sankey/SankeyView.ts
##########
@@ -250,7 +250,8 @@ class SankeyView extends ChartView {
width: layout.dx,
height: layout.dy
},
- style: itemModel.getModel('itemStyle').getItemStyle()
+ style: itemModel.getModel('itemStyle').getItemStyle(),
+ z2: 10
Review comment:
Sure. It's here. #14640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on a change in pull request #14417: Fix(sankey): sankey label has higher z2
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #14417:
URL: https://github.com/apache/echarts/pull/14417#discussion_r610620369
##########
File path: src/chart/sankey/SankeyView.ts
##########
@@ -250,7 +250,8 @@ class SankeyView extends ChartView {
width: layout.dx,
height: layout.dy
},
- style: itemModel.getModel('itemStyle').getItemStyle()
+ style: itemModel.getModel('itemStyle').getItemStyle(),
+ z2: 10
Review comment:
@pissang @susiwen8 Sorry here. I ever reverted it in #14542. But for now, this change seems to be still needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on a change in pull request #14417: Fix(sankey): sankey label has higher z2
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #14417:
URL: https://github.com/apache/echarts/pull/14417#discussion_r610714398
##########
File path: src/chart/sankey/SankeyView.ts
##########
@@ -250,7 +250,8 @@ class SankeyView extends ChartView {
width: layout.dx,
height: layout.dy
},
- style: itemModel.getModel('itemStyle').getItemStyle()
+ style: itemModel.getModel('itemStyle').getItemStyle(),
+ z2: 10
Review comment:
@plainheart Seems so, do you mind adding it before we vote for this release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #14417: Fix(sankey): sankey label has higher z2
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14417:
URL: https://github.com/apache/echarts/pull/14417#issuecomment-792292403
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #14417: Fix(sankey): sankey label has higher z2
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14417:
URL: https://github.com/apache/echarts/pull/14417#issuecomment-792411296
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org