[GitHub] timifasubaa commented on a change in pull request #4409: Add permissions decider for delegating access controls.

[GitBox <gi...@apache.org>]

timifasubaa commented on a change in pull request #4409: Add permissions decider for delegating access controls.
URL: https://github.com/apache/incubator-superset/pull/4409#discussion_r167971247
 
 

 ##########
 File path: superset/config.py
 ##########
 @@ -364,6 +364,24 @@ class CeleryConfig(object):
 # Interval between consecutive polls when using Hive Engine
 HIVE_POLL_INTERVAL = 5
 
+
+# System to handle delegated data access. Implement both is_allowed_access() and
+# is_eligible_datasource() to delegate access controls.
+class PermsDecider:
 
 Review comment:
   Agree that it should be a static class. 
   The concern is that if it is defined outside of config.py, there's no way to delegate access decisions to a system outside of superset. 
   
   Since perms_decider might only apply to a subset of databases ot datasources, If we use has_datasource_access, it's not clear what to return when the datasource in question is out of the jurisdiction of the perms_decider. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services