You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/03/23 06:53:10 UTC
[GitHub] [dubbo] kimmking commented on a change in pull request #9830: Optimize code for base practice for 3.x
kimmking commented on a change in pull request #9830:
URL: https://github.com/apache/dubbo/pull/9830#discussion_r832903562
##########
File path: dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/configurator/parser/model/ConfigItem.java
##########
@@ -28,6 +28,14 @@
public static final String WEIGHT_TYPE = "weight";
public static final String BALANCING_TYPE = "balancing";
public static final String DISABLED_TYPE = "disabled";
+ public static final String CONFIG_ITEM_TYPE = "type";
+ public static final String ENABLED_KEY ="enabled";
+ public static final String ADDRESSES_KEY="addresses";
Review comment:
need a blank.
##########
File path: dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/configurator/parser/model/ConfigItem.java
##########
@@ -28,6 +28,14 @@
public static final String WEIGHT_TYPE = "weight";
public static final String BALANCING_TYPE = "balancing";
public static final String DISABLED_TYPE = "disabled";
+ public static final String CONFIG_ITEM_TYPE = "type";
+ public static final String ENABLED_KEY ="enabled";
Review comment:
need a blank
##########
File path: dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/configurator/parser/model/ConfiguratorConfig.java
##########
@@ -26,7 +26,11 @@
public class ConfiguratorConfig {
public static final String SCOPE_SERVICE = "service";
public static final String SCOPE_APPLICATION = "application";
-
+ public static final String CONFIG_VERSION_KEY = "configVersion";
+ public static final String SCOPE_KEY = "scope";
+ public static final String CONFIG_KEY="key";
+ public static final String ENABLED_KEY="enabled";
Review comment:
And then I guess we can extract these same key to a Constants class？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org