You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pirk.apache.org by smarthi <gi...@git.apache.org> on 2016/08/01 00:47:19 UTC
[GitHub] incubator-pirk pull request #40: [nitpick]: change the forkCount to reliably...
GitHub user smarthi opened a pull request:
https://github.com/apache/incubator-pirk/pull/40
[nitpick]: change the forkCount to reliably execute tests in parallel\u2026
\u2026 and set reuseForks to False.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarthi/incubator-pirk nitpick
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-pirk/pull/40.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #40
----
commit 3b65c8c734284a39b8bbe9bf702574d6ba898990
Author: smarthi <sm...@apache.org>
Date: 2016-08-01T00:46:59Z
[nitpick]: change the forkCount to reliably execute tests in parallel and set reuseForks to False.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #40: [nitpick]: change the forkCount to reliably execut...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/40
Well yeah, I think we shud keep it at 1C. Travis and my machine were no better with 1C, so switched it to 2. But I agree we shuld keep it at 1C. Will close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #40: [nitpick]: change the forkCount to reliably execut...
Posted by ellisonanne <gi...@git.apache.org>.
Github user ellisonanne commented on the issue:
https://github.com/apache/incubator-pirk/pull/40
Why fix the forkCount at 2 instead of having it dynamic to the machine with 1C? Not opposed, just trying to understand the rationale of changing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #40: [nitpick]: change the forkCount to reliably...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi closed the pull request at:
https://github.com/apache/incubator-pirk/pull/40
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---