You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "catcherwong (via GitHub)" <gi...@apache.org> on 2024/07/12 03:55:17 UTC
[PR] [csharp] update TFM to net6 and net8 [rocketmq-clients]
catcherwong opened a new pull request, #799:
URL: https://github.com/apache/rocketmq-clients/pull/799
<!-- Please make sure the target branch is right. In most case, the target branch should be `master`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #770
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [csharp] update TFM to net6 and net8 [rocketmq-clients]
Posted by "catcherwong (via GitHub)" <gi...@apache.org>.
catcherwong commented on PR #799:
URL: https://github.com/apache/rocketmq-clients/pull/799#issuecomment-2227558470
I don't know why the build failed about macos-11, and no log for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [csharp] update TFM to net6 and net8 [rocketmq-clients]
Posted by "catcherwong (via GitHub)" <gi...@apache.org>.
catcherwong commented on code in PR #799:
URL: https://github.com/apache/rocketmq-clients/pull/799#discussion_r1706272468
##########
csharp/rocketmq-client-csharp/Client.cs:
##########
@@ -23,7 +23,7 @@
using System.Linq;
using Microsoft.Extensions.Logging;
using Proto = Apache.Rocketmq.V2;
-using grpc = Grpc.Core;
+using grpcLib = Grpc.Core;
Review Comment:
Fix ` warning CS8981: The type name
'grpc' only contains lower-cased ascii characters. Such names may become reserved for the language.` after upgrading the version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [csharp] update TFM to net6 and net8 [rocketmq-clients]
Posted by "lizhanhui (via GitHub)" <gi...@apache.org>.
lizhanhui commented on code in PR #799:
URL: https://github.com/apache/rocketmq-clients/pull/799#discussion_r1705334262
##########
csharp/rocketmq-client-csharp/Client.cs:
##########
@@ -23,7 +23,7 @@
using System.Linq;
using Microsoft.Extensions.Logging;
using Proto = Apache.Rocketmq.V2;
-using grpc = Grpc.Core;
+using grpcLib = Grpc.Core;
Review Comment:
Why rename this alias?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [csharp] update TFM to net6 and net8 [rocketmq-clients]
Posted by "lizhanhui (via GitHub)" <gi...@apache.org>.
lizhanhui merged PR #799:
URL: https://github.com/apache/rocketmq-clients/pull/799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [csharp] update TFM to net6 and net8 [rocketmq-clients]
Posted by "lizhanhui (via GitHub)" <gi...@apache.org>.
lizhanhui commented on PR #799:
URL: https://github.com/apache/rocketmq-clients/pull/799#issuecomment-2270973812
> I don't know why the build failed about macos-11, and no log for it.
Looks macos-11 is no longer available in public runners. Removed it from build matrix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [csharp] update TFM to net6 and net8 [rocketmq-clients]
Posted by "catcherwong (via GitHub)" <gi...@apache.org>.
catcherwong commented on PR #799:
URL: https://github.com/apache/rocketmq-clients/pull/799#issuecomment-2272489333
> Looks macos-11 is no longer available in public runners. Removed it from build matrix.
Based on https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/
I update from macos-11 to macos-12, the ci runs well now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org