You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2015/05/22 17:56:40 UTC

Re: Review Request 12885: Slave ping timeout may be increased by flags.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12885/#review84921
-----------------------------------------------------------


Is this obsoleted by https://reviews.apache.org/r/29507/?

- Niklas Nielsen


On July 30, 2013, 4:45 p.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12885/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 4:45 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Slave ping timeout may be increased by flags.
> 
> Review: https://reviews.apache.org/r/12885
> 
> 
> Diffs
> -----
> 
>   src/master/constants.hpp f3a95f1006472ff2b90cabb8cf74182830740954 
>   src/master/constants.cpp 7bc32eb3bdae717ded63436e47031934384eec23 
>   src/master/flags.hpp 6dbbb79d447991a4929fe27628961c0874adadf8 
>   src/master/master.cpp e4507acd97ebaf2ce693ec7343e9a4a563f6ff80 
>   src/tests/fault_tolerance_tests.cpp c8d88d5f60cf49ef5c1ffa429d308c30c2e5005c 
> 
> Diff: https://reviews.apache.org/r/12885/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Re: Review Request 12885: Slave ping timeout may be increased by flags.

Posted by Brenden Matthews <br...@diddyinc.com>.

> On May 22, 2015, 3:56 p.m., Niklas Nielsen wrote:
> > Is this obsoleted by https://reviews.apache.org/r/29507/?

Yes, I believe so.


- Brenden


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12885/#review84921
-----------------------------------------------------------


On July 30, 2013, 11:45 p.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12885/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 11:45 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Slave ping timeout may be increased by flags.
> 
> Review: https://reviews.apache.org/r/12885
> 
> 
> Diffs
> -----
> 
>   src/master/constants.hpp f3a95f1006472ff2b90cabb8cf74182830740954 
>   src/master/constants.cpp 7bc32eb3bdae717ded63436e47031934384eec23 
>   src/master/flags.hpp 6dbbb79d447991a4929fe27628961c0874adadf8 
>   src/master/master.cpp e4507acd97ebaf2ce693ec7343e9a4a563f6ff80 
>   src/tests/fault_tolerance_tests.cpp c8d88d5f60cf49ef5c1ffa429d308c30c2e5005c 
> 
> Diff: https://reviews.apache.org/r/12885/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>