[GitHub] [pulsar] flowchartsman commented on a diff in pull request #20404: [fix][fn] Go functions need to use static grpcPort in k8s runtime

["flowchartsman (via GitHub)" <gi...@apache.org>]

flowchartsman commented on code in PR #20404:
URL: https://github.com/apache/pulsar/pull/20404#discussion_r1207014840


##########
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeFactory.java:
##########
@@ -280,6 +280,8 @@ public KubernetesRuntime createContainer(InstanceConfig instanceConfig, String c
                 instanceFile = pythonInstanceFile;
                 break;
             case GO:
+                // Go functions should communicate via grpcPort directly.
+                instanceConfig.setPort(grpcPort);

Review Comment:
   Yeah, I was being too conservative. This is the right call.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org