You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/01 09:44:51 UTC

[GitHub] [incubator-doris] Gabriel39 opened a new pull request, #9344: [BUG] fix bug for vectorized compaction

Gabriel39 opened a new pull request, #9344:
URL: https://github.com/apache/incubator-doris/pull/9344

   # Proposed changes
   
   Issue Number: close #9343
   
   ## Problem Summary:
   
   Describe the overview of changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] Gabriel39 commented on pull request #9344: [BUG] fix bug for vectorized compaction

Posted by GitBox <gi...@apache.org>.

Gabriel39 commented on PR #9344:
URL: https://github.com/apache/incubator-doris/pull/9344#issuecomment-1114764511

   > Oh, I noticed that now the compaction operation is go through `vmerge_rowsets` directly without checking if vectorized is enabled. Is it safe? @Gabriel39 @HappenLee
   
   Config `enable_vectorized_compaction` has been added in last commit. Please review again @morningman 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9344: [BUG] fix bug for vectorized compaction

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #9344:
URL: https://github.com/apache/incubator-doris/pull/9344#issuecomment-1114188370

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morningman merged pull request #9344: [BUG] fix bug for vectorized compaction

Posted by GitBox <gi...@apache.org>.

morningman merged PR #9344:
URL: https://github.com/apache/incubator-doris/pull/9344


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9344: [BUG] fix bug for vectorized compaction

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #9344:
URL: https://github.com/apache/incubator-doris/pull/9344#issuecomment-1114188365

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9344: [BUG] fix bug for vectorized compaction

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #9344:
URL: https://github.com/apache/incubator-doris/pull/9344#issuecomment-1114795252

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] Gabriel39 commented on pull request #9344: [BUG] fix bug for vectorized compaction

Posted by GitBox <gi...@apache.org>.

Gabriel39 commented on PR #9344:
URL: https://github.com/apache/incubator-doris/pull/9344#issuecomment-1114186429

   cc @HappenLee 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morningman commented on pull request #9344: [BUG] fix bug for vectorized compaction

Posted by GitBox <gi...@apache.org>.

morningman commented on PR #9344:
URL: https://github.com/apache/incubator-doris/pull/9344#issuecomment-1114255641

   Oh, I noticed that now the compaction operation is go through `vmerge_rowsets` directly without checking if vectorized is enabled. Is it safe? @Gabriel39 @HappenLee 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org