You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/01 15:48:00 UTC
[jira] [Commented] (BEAM-859) Fix building with eclipse

    [ https://issues.apache.org/jira/browse/BEAM-859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625758#comment-15625758 ] 

ASF GitHub Bot commented on BEAM-859:
-------------------------------------

GitHub user dhalperi opened a pull request:

    https://github.com/apache/incubator-beam/pull/1247

    [BEAM-859] Move Eclipse precommit build to Java 8

    Also reorder env variables so it's clear what the precommit is.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/incubator-beam beam-859

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1247.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1247
    
----
commit 5f0c97998734e37a098e1d361e15256bd3452100
Author: Dan Halperin <dh...@google.com>
Date:   2016-10-28T16:20:17Z

    [BEAM-859] Move Eclipse precommit build to Java 8
    
    Also reorder env variables so it's clear what the precommit is.

----


> Fix building with eclipse
> -------------------------
>
>                 Key: BEAM-859
>                 URL: https://issues.apache.org/jira/browse/BEAM-859
>             Project: Beam
>          Issue Type: Bug
>          Components: build-system
>    Affects Versions: Not applicable
>            Reporter: Daniel Halperin
>            Assignee: Daniel Halperin
>            Priority: Minor
>             Fix For: Not applicable
>
>
> Kenn has gotten travis working more reliably, which has exposed that we broke the Eclipse travis build again.
> > I'm trying to debug some errors in the Eclipse travis check: https://s3.amazonaws.com/archive.travis-ci.org/jobs/170856465/log.txt
> >
> > Some online threads made me think it could be related to Java8 vs Java7. E.g., https://jira.nuxeo.com/browse/NXP-18655
> >
> > https://github.com/apache/incubator-beam/commit/957c545eaa33c861b561418b1c7dadf4c31f92f3#diff-354f30a63fb0907d4ad57269548329e3R42
> Maybe we should move the Eclipse test to Java8 instead of Java7 and see what happens.
> cc [~dkulp]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)