You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by Henrik K <he...@hege.li> on 2021/04/30 02:23:25 UTC
Re: svn commit: r1889308 - in /spamassassin/trunk:
rules/10_hasbase.cf rules/20_ratware.cf rulesrc/sandbox/billcole/80_test.cf
Please do not commit anything without make/lint check. :-(
lint: config: invalid regexp for SCC_NEWBIE_HASBEENS
'/\.(today|online|monster)': invalid end delimiter/mods at build/mkrules
line 262.
On Fri, Apr 30, 2021 at 01:37:58AM -0000, billcole@apache.org wrote:
> Author: billcole
> Date: Fri Apr 30 01:37:58 2021
> New Revision: 1889308
>
> URL: http://svn.apache.org/viewvc?rev=1889308&view=rev
> Log:
> Cosmetics of MAILING_LIST_MULTI and HAS/ML# duplicate, sandbox test rule housekeeping.
>
> Modified:
> spamassassin/trunk/rules/10_hasbase.cf
> spamassassin/trunk/rules/20_ratware.cf
> spamassassin/trunk/rulesrc/sandbox/billcole/80_test.cf
>
> Modified: spamassassin/trunk/rules/10_hasbase.cf
> URL: http://svn.apache.org/viewvc/spamassassin/trunk/rules/10_hasbase.cf?rev=1889308&r1=1889307&r2=1889308&view=diff
> ==============================================================================
> --- spamassassin/trunk/rules/10_hasbase.cf (original)
> +++ spamassassin/trunk/rules/10_hasbase.cf Fri Apr 30 01:37:58 2021
> @@ -56,7 +56,7 @@ header __HAS_TNEF exists:X-MS-TNEF-Cor
>
> header __HAS_ERRORS_TO exists:Errors-To
> header __HAS_ORIGINALLY exists:X-Originally-To
> -header __HAS_LIST_ID exists:List-Id
> +meta __HAS_LIST_ID __ML2
> header __HAS_X_BEEN_THERE exists:X-BeenThere
> header __HAS_X_REF exists:References
> header __HAS_IN_REPLY_TO exists:In-Reply-To
>
> Modified: spamassassin/trunk/rules/20_ratware.cf
> URL: http://svn.apache.org/viewvc/spamassassin/trunk/rules/20_ratware.cf?rev=1889308&r1=1889307&r2=1889308&view=diff
> ==============================================================================
> --- spamassassin/trunk/rules/20_ratware.cf (original)
> +++ spamassassin/trunk/rules/20_ratware.cf Fri Apr 30 01:37:58 2021
> @@ -114,8 +114,7 @@ header __HAS_X_LOOP exists:X-Loop
> header __HAS_X_MAILING_LIST exists:X-Mailing-List
> header __HAS_X_MAILMAN_VERSION exists:X-Mailman-Version
> describe MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager
> -# __ML2 and __HAS_LIST_ID are exactly equivalent, don't double-count
> -meta MAILING_LIST_MULTI __HAS_X_LOOP + __HAS_X_MAILING_LIST + __HAS_X_MAILMAN_VERSION + __HAS_LIST_ID + __HAS_X_BEEN_THERE +__DOS_HAS_LIST_UNSUB + __ML1 + __ML3 + __ML4 + __ML5 > 2
> +meta MAILING_LIST_MULTI __HAS_X_LOOP + __HAS_X_MAILING_LIST + __HAS_X_MAILMAN_VERSION + __HAS_X_BEEN_THERE +__DOS_HAS_LIST_UNSUB + __ML1 + __ML2 + __ML3 + __ML4 + __ML5 > 2
> tflags MAILING_LIST_MULTI nice
>
> # QUALCOMM Eudora
>
> Modified: spamassassin/trunk/rulesrc/sandbox/billcole/80_test.cf
> URL: http://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/billcole/80_test.cf?rev=1889308&r1=1889307&r2=1889308&view=diff
> ==============================================================================
> --- spamassassin/trunk/rulesrc/sandbox/billcole/80_test.cf (original)
> +++ spamassassin/trunk/rulesrc/sandbox/billcole/80_test.cf Fri Apr 30 01:37:58 2021
> @@ -22,8 +22,8 @@ meta __MIXED_IMG_CASE __HAS_IMG_SRC - _
> describe __MIXED_HREF_CASE Has anchor tags with mixed-up cases in non-quoted lines
> meta __MIXED_HREF_CASE __HAS_HREF - __HAS_HREF_ONECASE > 0
>
> -describe T_MIXED_TAG_CASE Has multiple mixed-case tags in non-quoted lines.
> -meta T_MIXED_TAG_CASE __MIXED_IMG_CASE && __MIXED_HREF_CASE
> +describe __MIXED_TAG_CASE Has multiple mixed-case tags in non-quoted lines.
> +meta __MIXED_TAG_CASE __MIXED_IMG_CASE && __MIXED_HREF_CASE
>
> describe T_SCC_THREE_WORD_MONTY Are you POTUS or a mass murderer?
> header T_SCC_THREE_WORD_MONTY From =~ /(\w{2,}) (\w{2,}) (\w{2,}) <\1.\2.\3/
> @@ -37,8 +37,8 @@ describe SCC_MAJORDOMO Multiple indicati
> meta SCC_MAJORDOMO __SCC_MD_UNSUB + __SCC_MD_SUB + __SCC_MD_SENDER + __SCC_MD_RCVD_OUT > 1
> tflags SCC_MAJORDOMO nice
>
> -describe T_SCC_ODD_MUA Unlikely MUA for a modern human
> -header T_SCC_ODD_MUA X-Mailer =~ /^X-Mailer: Microsoft Outlook 14.0$/
> +describe SCC_ODD_MUA Unlikely MUA for a modern human
> +header SCC_ODD_MUA X-Mailer =~ /^X-Mailer: Microsoft Outlook 14.0$/
>
>
> describe T_SCC_SPECIAL_GUID Unique in a similar way
> @@ -52,3 +52,6 @@ header __NO_EXTERNALS X-Spam-Relays-Ex
> describe ALL_INTERNAL Has only internal relays
> meta ALL_INTERNAL __NO_EXTERNALS && !NO_RELAYS
> tflags ALL_INTERNAL nice
> +
> +describe SCC_NEWBIE_HASBEENS Abused gTLDs seen in spam from Google Apps.
> +header SCC_NEWBIE_HASBEENS X-Beenthere =~ /\.(today|online|monster)
>
Re: svn commit: r1889308 - in /spamassassin/trunk:
rules/10_hasbase.cf rules/20_ratware.cf rulesrc/sandbox/billcole/80_test.cf
Posted by Henrik K <he...@hege.li>.
On Fri, Apr 30, 2021 at 07:29:41AM -0700, John Hardin wrote:
> On Fri, 30 Apr 2021, Henrik K wrote:
>
> >
> > Please do not commit anything without make/lint check. :-(
>
> > > -header __HAS_LIST_ID exists:List-Id
> > > +meta __HAS_LIST_ID __ML2
>
> Also, this should be the other way around - be consistent with
> __HAS_{headername} subrules being simply "the header exists", and if you
> want to alias it then make the *other* rule with the nonstandard name the
> meta.
+1 for changing it, feel free. I didn't bother to nitpick, but it did irk
me. :-)
Re: svn commit: r1889308 - in /spamassassin/trunk:
rules/10_hasbase.cf rules/20_ratware.cf rulesrc/sandbox/billcole/80_test.cf
Posted by Bill Cole <sa...@billmail.scconsult.com>.
On 30 Apr 2021, at 15:03, Benny Pedersen wrote:
> hopefully things can be stablinge in using the above module then just
> make another header check, if header check is not supported in the
> perl module it could be added
Doing header checks, even in complex combinations, is better done with
rules than to hide them away in Perl modules. If a particular tool (e.g.
Mailman 3, which is newer than that module) needs a new pattern of
headers, we can have it in widespread use in a matter of days if we
define it in rules. If it is embedded in code, it won't get used by most
people until their distro updates to a version newer than the current
trunk.
--
Bill Cole
bill@scconsult.com or billcole@apache.org
(AKA @grumpybozo and many *@billmail.scconsult.com addresses)
Not Currently Available For Hire
Re: svn commit: r1889308 - in /spamassassin/trunk:
rules/10_hasbase.cf rules/20_ratware.cf rulesrc/sandbox/billcole/80_test.cf
Posted by Benny Pedersen <me...@junc.eu>.
On 2021-04-30 19:04, Bill Cole wrote:
> Do you mean Mail::SpamAssassin::MailingList.pm?
yes
> That is an undocumented module which was last given specific attention
> in 2004, is not covered by the test suite, and is not used by any rule
> or any other SA module. I confess to being unaware of its existence
its sad that it is still not used :/
> when putting together the MAILING_LIST_MULTI rule but even now that I
> know, I do not see what benefit it would provide to use that (or any)
> module where a meta rule can suffice and be dynamically maintained. It
> seems more reasonable to just drop that module, as it seems likely
> that it has not been used by anyone for the past 10+ years, across
> many SA versions.
i still use postfix, its older then spamassassin imho :)
hopefully things can be stablinge in using the above module then just
make another header check, if header check is not supported in the perl
module it could be added
imho if we just check List-ID it simple not a maillist, but that is
maybe my opinion only, i see this only on opt out spam, not in opt-in
Re: svn commit: r1889308 - in /spamassassin/trunk:
rules/10_hasbase.cf rules/20_ratware.cf rulesrc/sandbox/billcole/80_test.cf
Posted by Bill Cole <bi...@apache.org>.
On 30 Apr 2021, at 12:05, Benny Pedersen wrote:
> On 2021-04-30 17:38, Bill Cole wrote:
>> On 30 Apr 2021, at 10:29, John Hardin wrote:
>>> On Fri, 30 Apr 2021, Henrik K wrote:
>>>> Please do not commit anything without make/lint check. :-(
>
> +1
>
>>>>> -header __HAS_LIST_ID exists:List-Id
>>>>> +meta __HAS_LIST_ID __ML2
>>>
>>> Also, this should be the other way around - be consistent with
>>> __HAS_{headername} subrules being simply "the header exists", and if
>>> you want to alias it then make the *other* rule with the nonstandard
>>> name the meta.
>>
>> I don't really have a preference one way or the other, only for not
>> having 2 identical but independent rules.
>
> maillist.pm exists ?
No, it does not. At least not anywhere I can find...
> imho detection on maillists should be made in this core module
Do you mean Mail::SpamAssassin::MailingList.pm?
That is an undocumented module which was last given specific attention
in 2004, is not covered by the test suite, and is not used by any rule
or any other SA module. I confess to being unaware of its existence when
putting together the MAILING_LIST_MULTI rule but even now that I know, I
do not see what benefit it would provide to use that (or any) module
where a meta rule can suffice and be dynamically maintained. It seems
more reasonable to just drop that module, as it seems likely that it has
not been used by anyone for the past 10+ years, across many SA versions.
--
Bill Cole
bill@scconsult.com or billcole@apache.org
(AKA @grumpybozo and many *@billmail.scconsult.com addresses)
Not Currently Available For Hire
Re: svn commit: r1889308 - in /spamassassin/trunk:
rules/10_hasbase.cf rules/20_ratware.cf rulesrc/sandbox/billcole/80_test.cf
Posted by Benny Pedersen <me...@junc.eu>.
On 2021-04-30 17:38, Bill Cole wrote:
> On 30 Apr 2021, at 10:29, John Hardin wrote:
>> On Fri, 30 Apr 2021, Henrik K wrote:
>>> Please do not commit anything without make/lint check. :-(
+1
>>>> -header __HAS_LIST_ID exists:List-Id
>>>> +meta __HAS_LIST_ID __ML2
>>
>> Also, this should be the other way around - be consistent with
>> __HAS_{headername} subrules being simply "the header exists", and if
>> you want to alias it then make the *other* rule with the nonstandard
>> name the meta.
>
> I don't really have a preference one way or the other, only for not
> having 2 identical but independent rules.
maillist.pm exists ?
imho detection on maillists should be made in this core module
Re: svn commit: r1889308 - in /spamassassin/trunk: rules/10_hasbase.cf
rules/20_ratware.cf rulesrc/sandbox/billcole/80_test.cf
Posted by John Hardin <jh...@impsec.org>.
On Fri, 30 Apr 2021, Bill Cole wrote:
> On 30 Apr 2021, at 10:29, John Hardin wrote:
>
>> On Fri, 30 Apr 2021, Henrik K wrote:
>>
>>>
>>> Please do not commit anything without make/lint check. :-(
>>
>>>> -header __HAS_LIST_ID exists:List-Id
>>>> +meta __HAS_LIST_ID __ML2
>>
>> Also, this should be the other way around - be consistent with
>> __HAS_{headername} subrules being simply "the header exists", and if you
>> want to alias it then make the *other* rule with the nonstandard name the
>> meta.
>
> I don't really have a preference one way or the other, only for not having 2
> identical but independent rules.
Agreed on the latter.
--
John Hardin KA7OHZ http://www.impsec.org/~jhardin/
jhardin@impsec.org pgpk -a jhardin@impsec.org
key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
Activism is a way for useless people to feel important,
even if the consequences of their activism are counterproductive
for those they claim to be helping and damaging
to the fabric of society as a whole. -- Thomas Sowell
-----------------------------------------------------------------------
Tomorrow: May Day - Remember 110 million people murdered by Communism
Re: svn commit: r1889308 - in /spamassassin/trunk:
rules/10_hasbase.cf rules/20_ratware.cf rulesrc/sandbox/billcole/80_test.cf
Posted by Bill Cole <sa...@billmail.scconsult.com>.
On 30 Apr 2021, at 10:29, John Hardin wrote:
> On Fri, 30 Apr 2021, Henrik K wrote:
>
>>
>> Please do not commit anything without make/lint check. :-(
>
>>> -header __HAS_LIST_ID exists:List-Id
>>> +meta __HAS_LIST_ID __ML2
>
> Also, this should be the other way around - be consistent with
> __HAS_{headername} subrules being simply "the header exists", and if
> you want to alias it then make the *other* rule with the nonstandard
> name the meta.
I don't really have a preference one way or the other, only for not
having 2 identical but independent rules.
--
Bill Cole
bill@scconsult.com or billcole@apache.org
(AKA @grumpybozo and many *@billmail.scconsult.com addresses)
Not Currently Available For Hire
Re: svn commit: r1889308 - in /spamassassin/trunk: rules/10_hasbase.cf
rules/20_ratware.cf rulesrc/sandbox/billcole/80_test.cf
Posted by John Hardin <jh...@impsec.org>.
On Fri, 30 Apr 2021, Henrik K wrote:
>
> Please do not commit anything without make/lint check. :-(
>> -header __HAS_LIST_ID exists:List-Id
>> +meta __HAS_LIST_ID __ML2
Also, this should be the other way around - be consistent with
__HAS_{headername} subrules being simply "the header exists", and if you
want to alias it then make the *other* rule with the nonstandard name the
meta.
--
John Hardin KA7OHZ http://www.impsec.org/~jhardin/
jhardin@impsec.org pgpk -a jhardin@impsec.org
key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
Law is too dangerous a tool to leave in the hands of
opposing tribes who just want to use it to
bludgeon one another. -- J.D. Tuccile
-----------------------------------------------------------------------
Tomorrow: May Day - Remember 110 million people murdered by Communism