You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2019/12/28 05:59:15 UTC

[GitHub] [lucene-solr] dsmiley commented on issue #1124: SOLR-14151 :Schema components to be loadable from packages

dsmiley commented on issue #1124: SOLR-14151 :Schema components to be loadable from packages
URL: https://github.com/apache/lucene-solr/pull/1124#issuecomment-569389280
 
 
   > So, the solution to the problem is we will make `SolrClassLoader extends ResourceLoader` and this will be the interface which will be passed around. 
   
   Sounds workable.
   
   > We will stop relying on SRL because SRL does too many things already. Piling on more things into an already bloated class is at best a hack. It's not a good idea to say that A package returns an SRL because most of the methods are invalid for such a use case
   
   I'm curious; what is some of the bloat of SRL that you think it should not do?
   
   > The behavior of `SolrCoreAware` and `ResourceLoaderAware` is fixed in the latest commit
   
   I'm glad to see that!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org