You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/20 08:59:22 UTC

[GitHub] [flink] qinjunjerry opened a new pull request #16542: [FLINK-23429][state-processor-api] Use Path instead of Path.getPath()…

qinjunjerry opened a new pull request #16542:
URL: https://github.com/apache/flink/pull/16542


   … to preserve FileSystem info
   
   ## What is the purpose of the change
   
   Fix an FileNotFoundException in State Processor API when working with savepoints on cloud storage
   
   ## Brief change log
   
   - Use Path instead of a String Path.getPath() in StatePathExtractor to preserve FileSystem info such that FileCopyFunction can copy files even if they are on cloud storage.
   
   
   ## Verifying this change
   
   I've tested this fix with Azure blob storage and AWS S3. 
   
   This change added tests and can be verified as follows:
   
   - Manually create an S3 bucket or an Azure blob container
   - Configure a Flink cluster with s3-fs-presto or azure-fs-haoop plugin enabled
   - Start a Flink a job and create a savepoint on S3/azure
   - Use state processor API to transform the savepoint to a new one and store it in a new location on S3/azure
   - There should not FileNotFoundException
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers:no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16542: [FLINK-23429][state-processor-api] Use Path instead of Path.getPath()…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #16542:
URL: https://github.com/apache/flink/pull/16542#issuecomment-883248392


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "007df374754416b706fe756c084fd7244101d2a9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20732",
       "triggerID" : "007df374754416b706fe756c084fd7244101d2a9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 007df374754416b706fe756c084fd7244101d2a9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20732) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16542: [FLINK-23429][state-processor-api] Use Path instead of Path.getPath()…

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #16542:
URL: https://github.com/apache/flink/pull/16542#issuecomment-883226469






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] qinjunjerry commented on pull request #16542: [FLINK-23429][state-processor-api] Use Path instead of Path.getPath()…

Posted by GitBox <gi...@apache.org>.

qinjunjerry commented on pull request #16542:
URL: https://github.com/apache/flink/pull/16542#issuecomment-883715024


   Yes, we should back port to 1.13. Will create a new PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16542: [FLINK-23429][state-processor-api] Use Path instead of Path.getPath()…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #16542:
URL: https://github.com/apache/flink/pull/16542#issuecomment-883226469

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 007df374754416b706fe756c084fd7244101d2a9 (Thu Sep 23 18:08:16 UTC 2021)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16542: [FLINK-23429][state-processor-api] Use Path instead of Path.getPath()…

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #16542:
URL: https://github.com/apache/flink/pull/16542#issuecomment-883226469

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 007df374754416b706fe756c084fd7244101d2a9 (Tue Jul 20 09:01:42 UTC 2021)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.
## Review Progress

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sjwiesman closed pull request #16542: [FLINK-23429][state-processor-api] Use Path instead of Path.getPath()…

Posted by GitBox <gi...@apache.org>.

sjwiesman closed pull request #16542:
URL: https://github.com/apache/flink/pull/16542


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16542: [FLINK-23429][state-processor-api] Use Path instead of Path.getPath()…

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #16542:
URL: https://github.com/apache/flink/pull/16542#issuecomment-883226469

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 007df374754416b706fe756c084fd7244101d2a9 (Tue Jul 20 09:01:42 UTC 2021)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.
## Review Progress

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16542: [FLINK-23429][state-processor-api] Use Path instead of Path.getPath()…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #16542:
URL: https://github.com/apache/flink/pull/16542#issuecomment-883248392


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "007df374754416b706fe756c084fd7244101d2a9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20732",
       "triggerID" : "007df374754416b706fe756c084fd7244101d2a9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 007df374754416b706fe756c084fd7244101d2a9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20732) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16542: [FLINK-23429][state-processor-api] Use Path instead of Path.getPath()…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #16542:
URL: https://github.com/apache/flink/pull/16542#issuecomment-883248392


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "007df374754416b706fe756c084fd7244101d2a9",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20732",
       "triggerID" : "007df374754416b706fe756c084fd7244101d2a9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 007df374754416b706fe756c084fd7244101d2a9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20732) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16542: [FLINK-23429][state-processor-api] Use Path instead of Path.getPath()…

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #16542:
URL: https://github.com/apache/flink/pull/16542#issuecomment-883248392


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "007df374754416b706fe756c084fd7244101d2a9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "007df374754416b706fe756c084fd7244101d2a9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 007df374754416b706fe756c084fd7244101d2a9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org