You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by gi...@git.apache.org on 2017/07/05 20:18:06 UTC

[GitHub] sebastianrothbucher opened a new pull request #646: Make map functions distinct with each invocation

sebastianrothbucher opened a new pull request #646: Make map functions distinct with each invocation
URL: https://github.com/apache/couchdb/pull/646
 
 
   ## Overview
   [Issue 548](https://github.com/apache/couchdb/issues/548) points out that tests fail randomly when using ad-hoc queries (i.e. create a design doc, query it, remove it again). Though I can't reproduce it (not even by doing this cycle three times in a row without wait in-between), there is a solution by simply adding comments to the map function (hence changing the signature, allowing two otherwise similar views to co-exist. As it's hardly production relevant (design docs likely won't and probably shouldn't be created and removed all the time - it's a performance no-go in most cases), we actually get *better* tests as they really indicate if things go wrong (instead of failing randomly and being ignored after some time).
   
   In short: improves the quality of javascript tests
   
   ## Testing recommendations
   This IS a test
   
   ## GitHub issue number
   [Issue 548](https://github.com/apache/couchdb/issues/548)
   
   ## Related Pull Requests
   (none)
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - n/a Documentation reflects the changes; 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services