You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2025/12/09 17:29:41 UTC
[PR] Prepare providers release 2025-12-09 [airflow]
potiuk opened a new pull request, #59249:
URL: https://github.com/apache/airflow/pull/59249
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare providers release 2025-12-09 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #59249:
URL: https://github.com/apache/airflow/pull/59249#discussion_r2604479673
##########
providers/edge3/docs/changelog.rst:
##########
@@ -27,6 +27,9 @@
Changelog
---------
+2.0.0
Review Comment:
Not really - because we will make eventually a bit "fuss" about the removal and tell people not to use it.
I thought it's important to mark it as 2.* - becuase we are going to say - this version does not work with Airflow 2 any more (in case you used it this way)
Do you see any problem with it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare providers release 2025-12-09 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #59249:
URL: https://github.com/apache/airflow/pull/59249#discussion_r2604524490
##########
providers/edge3/docs/changelog.rst:
##########
@@ -27,6 +27,9 @@
Changelog
---------
+2.0.0
Review Comment:
I personally think of SemVer numbers as mostly a communication tool. SemVer is really about intentions. And in this case, I believe our intention is to remove **some** functionality that we - a bit accidentally - made available to our users.
Of course our users should not rally use it - it was not intended for public consumption, so technically speaking it's not really breaking because it was not intentional
But because of the "auto-enabling" of AIP-44, on installing and configuring edge, even if not intended it became a feature for edge provider to work on Airlfow 2. As a users, I would be surprised not seeing it as a "breaking" change. Imagine your Bosch (yay! I got spelling right this time!) installation still running on Airlfow 2 and suddenly next version of edge3 cannot be installed - that I would say quite a problem.e
We had three choices:
* 1.6.1 -> this would be strange with such a drop of Airflow 2 support (again even if not intentional)
* 1.7.0 -> we have not added any feature, so that would be pretty akward
* 2.0.0 -> this signal significant change (and we also have warning in changelog) - some users are potentially affected
So I thought that bumping major version would be a nice signal to cut off any ties with Airflow 2.
That was my thinking at least.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare providers release 2025-12-09 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #59249: Prepare providers release 2025-12-09
URL: https://github.com/apache/airflow/pull/59249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare providers release 2025-12-09 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #59249:
URL: https://github.com/apache/airflow/pull/59249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare providers release 2025-12-09 [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #59249:
URL: https://github.com/apache/airflow/pull/59249#discussion_r2604534593
##########
providers/edge3/docs/changelog.rst:
##########
@@ -27,6 +27,9 @@
Changelog
---------
+2.0.0
Review Comment:
All good. I heard these people at Bosch still working hard to get to AF3. So they most likely will not be affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare providers release 2025-12-09 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #59249: Prepare providers release 2025-12-09
URL: https://github.com/apache/airflow/pull/59249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare providers release 2025-12-09 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #59249:
URL: https://github.com/apache/airflow/pull/59249#issuecomment-3633438617
and "allow provider dependency bump" -> both are needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare providers release 2025-12-09 [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #59249:
URL: https://github.com/apache/airflow/pull/59249#discussion_r2604451193
##########
providers/edge3/docs/changelog.rst:
##########
@@ -27,6 +27,9 @@
Changelog
---------
+2.0.0
Review Comment:
Oh, coming too late - you make this a major breaking? I thought as "experimental" we must make a 1.7.0 out of this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare providers release 2025-12-09 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #59249:
URL: https://github.com/apache/airflow/pull/59249#issuecomment-3633430386
Reopened with `skip common compat check` label added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare providers release 2025-12-09 [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #59249:
URL: https://github.com/apache/airflow/pull/59249#discussion_r2604483547
##########
providers/edge3/docs/changelog.rst:
##########
@@ -27,6 +27,9 @@
Changelog
---------
+2.0.0
Review Comment:
No problem - just surprised because except we dropped a lot of back-compat shim no real functional change or "breaking" stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org