You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2023/05/25 18:45:08 UTC
[GitHub] [arrow-adbc] zeroshade opened a new pull request, #709: fix(go/adbc/drivermgr): go doesn't package symbolic links
zeroshade opened a new pull request, #709:
URL: https://github.com/apache/arrow-adbc/pull/709
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade merged pull request #709: fix(go/adbc/drivermgr): go doesn't package symbolic links
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #709:
URL: https://github.com/apache/arrow-adbc/pull/709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #709: fix(go/adbc/drivermgr): go doesn't package symbolic links
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #709:
URL: https://github.com/apache/arrow-adbc/pull/709#discussion_r1205897211
##########
.pre-commit-config.yaml:
##########
@@ -86,5 +86,10 @@ repos:
language: script
pass_filenames: false
entry: "./ci/scripts/run_rat_local.sh"
+ - id: check-cgo-adbc-header
+ name: Ensure CGO adbc.h is sync'd
+ language: script
+ pass_filenames: false
+ entry: "./ci/scripts/run_cgo_drivermgr_check.sh"
Review Comment:
Maybe include a [`files`](https://pre-commit.com/#hooks-files) filter so this only runs when necessary?
You could go a step further and have it pass filenames, then the script could check each of the given files against its copy in `go/adbc/drivermgr` (that might be a bit too fancy though).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade commented on a diff in pull request #709: fix(go/adbc/drivermgr): go doesn't package symbolic links
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #709:
URL: https://github.com/apache/arrow-adbc/pull/709#discussion_r1205898123
##########
.pre-commit-config.yaml:
##########
@@ -86,5 +86,10 @@ repos:
language: script
pass_filenames: false
entry: "./ci/scripts/run_rat_local.sh"
+ - id: check-cgo-adbc-header
+ name: Ensure CGO adbc.h is sync'd
+ language: script
+ pass_filenames: false
+ entry: "./ci/scripts/run_cgo_drivermgr_check.sh"
Review Comment:
i missed that, i was trying to find it haha. nice :) i'll update with that filter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade commented on a diff in pull request #709: fix(go/adbc/drivermgr): go doesn't package symbolic links
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #709:
URL: https://github.com/apache/arrow-adbc/pull/709#discussion_r1205917965
##########
.pre-commit-config.yaml:
##########
@@ -86,5 +86,10 @@ repos:
language: script
pass_filenames: false
entry: "./ci/scripts/run_rat_local.sh"
+ - id: check-cgo-adbc-header
+ name: Ensure CGO adbc.h is sync'd
+ language: script
+ pass_filenames: false
+ entry: "./ci/scripts/run_cgo_drivermgr_check.sh"
Review Comment:
updated using the files filter, let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org