[jira] [Commented] (YARN-1741) XInclude support broken for YARN ResourceManager

["Sangjin Lee (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14043620#comment-14043620 ] 

Sangjin Lee commented on YARN-1741:
-----------------------------------

+1 with the idea for the ConfigurationProvider to return a tuple object of (input stream, system id).

> XInclude support broken for YARN ResourceManager
> ------------------------------------------------
>
>                 Key: YARN-1741
>                 URL: https://issues.apache.org/jira/browse/YARN-1741
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.4.0
>            Reporter: Eric Sirianni
>            Priority: Critical
>              Labels: regression
>
> The XInclude support in Hadoop configuration files (introduced via HADOOP-4944) was broken by the recent {{ConfigurationProvider}} changes to YARN ResourceManager.  Specifically, YARN-1459 and, more generally, the YARN-1611 family of JIRAs for ResourceManager HA.
> The issue is that {{ConfigurationProvider}} provides a raw {{InputStream}} as a {{Configuration}} resource for what was previously a {{Path}}-based resource.  
> For {{Path}} resources, the absolute file path is used as the {{systemId}} for the {{DocumentBuilder.parse()}} call:
> {code}
>       } else if (resource instanceof Path) {          // a file resource
> ...
>           doc = parse(builder, new BufferedInputStream(
>               new FileInputStream(file)), ((Path)resource).toString());
>         }
> {code}
> The {{systemId}} is used to resolve XIncludes (among other things):
> {code}
>     /**
>      * Parse the content of the given <code>InputStream</code> as an
>      * XML document and return a new DOM Document object.
> ...
>      * @param systemId Provide a base for resolving relative URIs.
> ...
>      */
>     public Document parse(InputStream is, String systemId)
> {code}
> However, for loading raw {{InputStream}} resources, the {{systemId}} is set to {{null}}:
> {code}
>       } else if (resource instanceof InputStream) {
>         doc = parse(builder, (InputStream) resource, null);
> {code}
> causing XInclude resolution to fail.
> In our particular environment, we make extensive use of XIncludes to standardize common configuration parameters across multiple Hadoop clusters.



--
This message was sent by Atlassian JIRA
(v6.2#6252)