You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/02 13:40:57 UTC
[GitHub] [airflow] nuclearpinguin commented on a change in pull request
#6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
nuclearpinguin commented on a change in pull request #6965: [AIRFLOW-6107] [AIP-21] Rename GKE operators and hook
URL: https://github.com/apache/airflow/pull/6965#discussion_r362475833
##########
File path: UPDATING.md
##########
@@ -445,9 +445,9 @@ The following table shows changes in import paths.
|airflow.contrib.operators.gcp_compute_operator.GceInstanceStopOperator |airflow.gcp.operators.compute.GceInstanceStopOperator |
|airflow.contrib.operators.gcp_compute_operator.GceInstanceTemplateCopyOperator |airflow.gcp.operators.compute.GceInstanceTemplateCopyOperator |
|airflow.contrib.operators.gcp_compute_operator.GceSetMachineTypeOperator |airflow.gcp.operators.compute.GceSetMachineTypeOperator |
-|airflow.contrib.operators.gcp_container_operator.GKEClusterCreateOperator |airflow.gcp.operators.kubernetes_engine.GKEClusterCreateOperator |
-|airflow.contrib.operators.gcp_container_operator.GKEClusterDeleteOperator |airflow.gcp.operators.kubernetes_engine.GKEClusterDeleteOperator |
-|airflow.contrib.operators.gcp_container_operator.GKEPodOperator |airflow.gcp.operators.kubernetes_engine.GKEPodOperator |
+|airflow.contrib.operators.gcp_container_operator.ComputeEngineCreateClusterOperator |airflow.gcp.operators.kubernetes_engine.ComputeEngineCreateClusterOperator |
Review comment:
@michalslowikowski00 I think we want to have
```
airflow.gcp.operators.container.GKECreateClusterOperator
airflow.gcp.operators.container.GKEDeleteClusterOperator
```
instead of
```
airflow.gcp.operators.container.ComputeEngineCreateClusterOperator
airflow.gcp.operators.container.ComputeEngineDeleteClusterOperator
```
@mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services