You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by soralee <gi...@git.apache.org> on 2017/02/22 05:43:48 UTC

[GitHub] zeppelin pull request #2054: remove border and margin

GitHub user soralee opened a pull request:

    https://github.com/apache/zeppelin/pull/2054

    remove border and margin

    ### What is this PR for?
    This PR is for removing border and margin of paragraph shape in new window which is created by "Link this paragraph" operation.
    It would be nice and neat to be removed such like that is suggested at [this comment](https://github.com/apache/zeppelin/pull/1983#issuecomment-279395050).
    
    
    ### What type of PR is it?
    [Improvement]
    
    ### What is the Jira issue?
    [ZEPPELIN-2113](https://issues.apache.org/jira/browse/ZEPPELIN-2113)
    
    
    ### How should this be tested?
    1. Click `Link this paragraph`
    2. Check a paragraph shape
    
    ### Screenshots (if appropriate)
    [ Before ]
    ![z_2113_b](https://cloud.githubusercontent.com/assets/8110458/23198655/8ab1879e-f90c-11e6-868c-3786d552ed80.png)
    
    ![image](https://cloud.githubusercontent.com/assets/8110458/23198733/f55116d2-f90c-11e6-9991-70261e1b0143.png)
    
    
    [ After ]
    ![z_2113_a](https://cloud.githubusercontent.com/assets/8110458/23198666/9c31a102-f90c-11e6-9a37-0b3c2bfe0fe2.png)
    
    ![z_2113_a_t](https://cloud.githubusercontent.com/assets/8110458/23198668/9ff8d954-f90c-11e6-9602-a9b5cfbb034b.png)
    
    
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin ZEPPELIN-2113_remove_border_margin

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2054.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2054
    
----
commit e47cc57e49e127644f00370a5b54fee0ff9dd339
Author: soralee <so...@zepl.com>
Date:   2017-02-22T04:41:31Z

    remove border and margin

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2054: [ZEPPELIN-2113] Remove border and margin of Link this ...

Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2054
  
    @1ambda Thanks for taking a look this!
    Regarding text layout, I don't consider left-pending because it already fixed #1983.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2054: [ZEPPELIN-2113] Remove border and margin of Lin...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2054


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2054: [ZEPPELIN-2113] Remove border and margin of Link this ...

Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2054
  
    My CI is green! (https://travis-ci.org/soralee/zeppelin/builds/204074604)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2054: [ZEPPELIN-2113] Remove border and margin of Link this ...

Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2054
  
    @prabhjyotsingh Thanks for review!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2054: [ZEPPELIN-2113] Remove border and margin of Link this ...

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2054
  
    Merging this if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2054: [ZEPPELIN-2113] Remove border and margin of Link this ...

Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2054
  
    I will review and comment soon. Thanks for fixing bug @soralee!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2054: [ZEPPELIN-2113] Remove border and margin of Link this ...

Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2054
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2054: [ZEPPELIN-2113] Remove border and margin of Link this ...

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2054
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2054: [ZEPPELIN-2113] Remove border and margin of Link this ...

Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2054
  
    @1ambda Thanks for review :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---