You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by GitBox <gi...@apache.org> on 2020/08/19 23:15:24 UTC
[GitHub] [karaf] amusarra opened a new pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
amusarra opened a new pull request #1160:
URL: https://github.com/apache/karaf/pull/1160
I made this pull request with the aim of adding the ability to build multi-platform Apache Karaf docker image and specifically for ARM and ARM64.
For me this solution is handy for being able to run Apache Karaf containers on Raspberry Pi.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
jbonofre commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475723140
##########
File path: assemblies/docker/Dockerfile
##########
@@ -16,7 +16,7 @@
# limitations under the License.
################################################################################
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim
Review comment:
The problem is not about the version (11 is fine and good idea) it's more the ea-28-slim which is a early access image. Please consider to use 11-jre (LTS).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] amusarra commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
amusarra commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475799636
##########
File path: assemblies/docker/Dockerfile
##########
@@ -16,7 +16,7 @@
# limitations under the License.
################################################################################
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim
Review comment:
@skitt and @jbonofre I just installed the Apache Karaf image for ARM based on `adoptopenjdk: 11-jre-hotspot` image on my Raspberry Pi and it works fine. The image I built is this [amusarra/karaf:4.2.9-dev](https://hub.docker.com/layers/amusarra/karaf/4.2.9-dev/images/sha256-8de5205d81263099628cf7659cdd8c648bd13b12cf9cc036f46d9426992927b5?context=explore)
Let me know if you have any doubts, in case I commit the dockerfile and update the README.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] amusarra commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
amusarra commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475771634
##########
File path: assemblies/docker/Dockerfile
##########
@@ -16,7 +16,7 @@
# limitations under the License.
################################################################################
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim
Review comment:
OK. Then I'll update to `adoptopenjdk:11-jre-hotspot` and do a test on arm (on my Raspberry Pi) to make sure everything works. OK?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] skitt commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
skitt commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475724499
##########
File path: assemblies/docker/Dockerfile
##########
@@ -16,7 +16,7 @@
# limitations under the License.
################################################################################
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim
Review comment:
I’m not objecting to the choice of version, but to the choice of image. The 8-jre images are still maintained, and were last updated 12 days ago, with a recent [build of OpenJDK](https://blog.adoptopenjdk.net/2020/07/adoptopenjdk-8u265-available/); the 11-ea-28-slim images haven’t been touched for two years and have known security issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] amusarra commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
amusarra commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475746554
##########
File path: assemblies/docker/Dockerfile
##########
@@ -16,7 +16,7 @@
# limitations under the License.
################################################################################
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim
Review comment:
Could this image be used adoptopenjdk: 11-jre-hotspot-bionic? I saw that it also includes ARM architectures and the image is up to date. What are you saying? Could I try this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] skitt commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
skitt commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475715549
##########
File path: assemblies/docker/Dockerfile
##########
@@ -16,7 +16,7 @@
# limitations under the License.
################################################################################
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim
Review comment:
This is an obsolete, early-access image; please don’t use that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] amusarra commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
amusarra commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475733066
##########
File path: assemblies/docker/Dockerfile
##########
@@ -16,7 +16,7 @@
# limitations under the License.
################################################################################
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim
Review comment:
Unfortunately the 8-jre alpine version for ARM does not work well on ARM devices because it uses OpenJDK Zero. Of version 11 I only found this image which also works on ARM devices. Since the original dockerfile referred to OpenJDK I did not take into consideration other images such as adoptopenjdk ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre merged pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
jbonofre merged pull request #1160:
URL: https://github.com/apache/karaf/pull/1160
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] skitt commented on pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
skitt commented on pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#issuecomment-681681975
I just checked this locally, and it works for me too, see https://quay.io/repository/skitt/karaf for the resulting image (with its three supported platforms).
Regarding next steps, please squash your commits into one. I suspect @jbonofre will want to review this too (he’s already self-requested one).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] amusarra commented on pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
amusarra commented on pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#issuecomment-679420050
I wanted to contribute as a user of Apache Karaf that develops OSGi solutions that also run on ARM architectures, see Raspberry Pi. Just yesterday I published an article about it [Raspberry Pi: How to run Apache Karaf 4.2 Docker Container](https://bit.ly/raspberrypi-how-to-run-apache-karaf-docker-container)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] amusarra commented on pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
amusarra commented on pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#issuecomment-681206106
Hi @skitt as you can see from the attached images, the Apache Karaf 4.2.9 Docker image for ARM64 runs correctly.
Now how do we want to proceed with the pull request? Does it have to pass further reviews?
Let me know.
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] skitt commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
skitt commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475791747
##########
File path: assemblies/docker/Dockerfile
##########
@@ -16,7 +16,7 @@
# limitations under the License.
################################################################################
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim
Review comment:
That would be great, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] skitt commented on pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
skitt commented on pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#issuecomment-681928118
@amusarra thank you for your contribution, it’s much appreciated, as is your willingness to fix the issues found during the review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] skitt commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
skitt commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r473834347
##########
File path: assemblies/docker/README.md
##########
@@ -26,6 +26,10 @@ https://docs.docker.com/installation/
Install the most recent stable version of docker-compose
https://docs.docker.com/compose/install/
+If you want build the multi platform (OS/Arch) docker image, then you must install
+the [buildx](https://docs.docker.com/buildx/working-with-buildx/). You can install
+[Docker Desktop Edge](https://docs.docker.com/docker-for-mac/edge-release-notes/) release for getting the buildx.
Review comment:
```suggestion
If you want to build multi-platform (OS/Arch) Docker images, then you must install
[`buildx`](https://docs.docker.com/buildx/working-with-buildx/).
On macOS, an easy way to install `buildx` is to install [Docker Desktop Edge](https://docs.docker.com/docker-for-mac/edge-release-notes/).
```
##########
File path: assemblies/docker/README.md
##########
@@ -48,6 +52,55 @@ you can configure it with the `KARAF_VERSION` arg:
docker build --build-arg KARAF_VERSION=4.2.0 -t "karaf:4.2.0" karaf
```
+If you want to build the container for a specific version of Karaf and
+specific version of the platform and finally push on the docker hub repository,
+you can configure it with the command:
Review comment:
```suggestion
If you want to build the container for a specific version of Karaf and
specific version of the platform, and push the image to the Docker Hub repository,
you can use this command (replacing the version, image name, and targets as appropriate):
```
##########
File path: assemblies/docker/build.sh
##########
@@ -21,11 +21,15 @@
usage() {
cat <<HERE
Usage:
- build.sh --from-local-dist [--archive <archive>] [--image-name <image>]
- build.sh --from-release --karaf-version <x.x.x> [--image-name <image>]
+ build.sh --from-local-dist [--archive <archive>] [--image-name <image>] [--build-multi-platform <string array of platform>]
+ build.sh --from-release --karaf-version <x.x.x> [--image-name <image>] [--build-multi-platform <string array of platform>]
build.sh --help
If the --image-name flag is not used the built image name will be 'karaf'.
+ Check supported platform to build, you can verify with this command: docker buildx ls
+ The supported platform (OS/Arch) depend on image from build, in this case the
+ image is openjdk:8u212-jre-alpine https://hub.docker.com/_/openjdk?tab=tags&page=1&name=8u212-jre-alpine
Review comment:
```suggestion
Check the supported build platforms; you can verify with this command: `docker buildx ls`
The supported platforms (OS/Arch) depend on the build's base image, in this case [`openjdk:8u212-jre-alpine`](https://hub.docker.com/_/openjdk?tab=tags&page=1&name=8u212-jre-alpine).
```
##########
File path: assemblies/docker/build.sh
##########
@@ -21,11 +21,15 @@
usage() {
cat <<HERE
Usage:
- build.sh --from-local-dist [--archive <archive>] [--image-name <image>]
- build.sh --from-release --karaf-version <x.x.x> [--image-name <image>]
+ build.sh --from-local-dist [--archive <archive>] [--image-name <image>] [--build-multi-platform <string array of platform>]
+ build.sh --from-release --karaf-version <x.x.x> [--image-name <image>] [--build-multi-platform <string array of platform>]
Review comment:
```suggestion
build.sh --from-local-dist [--archive <archive>] [--image-name <image>] [--build-multi-platform <comma-separated platforms>]
build.sh --from-release --karaf-version <x.x.x> [--image-name <image>] [--build-multi-platform <comma-separated platforms>]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] amusarra commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
amusarra commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475721520
##########
File path: assemblies/docker/Dockerfile
##########
@@ -16,7 +16,7 @@
# limitations under the License.
################################################################################
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim
Review comment:
I put version 11 also supported by Karaf. If you consider first there was version 8!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] amusarra commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
amusarra commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475799636
##########
File path: assemblies/docker/Dockerfile
##########
@@ -16,7 +16,7 @@
# limitations under the License.
################################################################################
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim
Review comment:
@skitt and @jbonofre I just installed the `adoptopenjdk: 11-jre-hotspot` based Apache Karaf image for ARM on my Raspberry Pi and it works fine. The image I built is this [amusarra/karaf:4.2.9-dev](https://hub.docker.com/layers/amusarra/karaf/4.2.9-dev/images/sha256-8de5205d81263099628cf7659cdd8c648bd13b12cf9cc036f46d9426992927b5?context=explore)
Let me know if you have any doubts, in case I commit the dockerfile and update the README.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] amusarra commented on pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
amusarra commented on pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#issuecomment-677509461
Hi @skitt. Thanks for suggestion that just committed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] amusarra commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
amusarra commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475799636
##########
File path: assemblies/docker/Dockerfile
##########
@@ -16,7 +16,7 @@
# limitations under the License.
################################################################################
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim
Review comment:
@skitt and @jbonofre I just installed the Apache Karaf `adoptopenjdk: 11-jre-hotspot` based on image for ARM on my Raspberry Pi and it works fine. The image I built is this [amusarra/karaf:4.2.9-dev](https://hub.docker.com/layers/amusarra/karaf/4.2.9-dev/images/sha256-8de5205d81263099628cf7659cdd8c648bd13b12cf9cc036f46d9426992927b5?context=explore)
Let me know if you have any doubts, in case I commit the dockerfile and update the README.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] amusarra commented on pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
amusarra commented on pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#issuecomment-681920950
@skitt and @jbonofre many thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] skitt commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
skitt commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r475756112
##########
File path: assemblies/docker/Dockerfile
##########
@@ -16,7 +16,7 @@
# limitations under the License.
################################################################################
-FROM openjdk:8-jre
+FROM openjdk:11-ea-28-slim
Review comment:
`adoptopenjdk:11-jre-hotspot` would be better: they provide Windows builds too, and by referencing `11-jre-hotspot` instead of `...-bionic`, if the Linux-based 11 images switch to a base other than Bionic we’ll still get updates.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] amusarra commented on pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
amusarra commented on pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#issuecomment-681797896
Hi @skitt I just squashed the ten commits. Ready for review by @jbonofre
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] amusarra commented on a change in pull request #1160: Feature/add build docker image multi-platform (OS/Arch)
Posted by GitBox <gi...@apache.org>.
amusarra commented on a change in pull request #1160:
URL: https://github.com/apache/karaf/pull/1160#discussion_r473848765
##########
File path: assemblies/docker/README.md
##########
@@ -26,6 +26,10 @@ https://docs.docker.com/installation/
Install the most recent stable version of docker-compose
https://docs.docker.com/compose/install/
+If you want build the multi platform (OS/Arch) docker image, then you must install
+the [buildx](https://docs.docker.com/buildx/working-with-buildx/). You can install
+[Docker Desktop Edge](https://docs.docker.com/docker-for-mac/edge-release-notes/) release for getting the buildx.
Review comment:
Thanks for suggestion.
##########
File path: assemblies/docker/README.md
##########
@@ -48,6 +52,55 @@ you can configure it with the `KARAF_VERSION` arg:
docker build --build-arg KARAF_VERSION=4.2.0 -t "karaf:4.2.0" karaf
```
+If you want to build the container for a specific version of Karaf and
+specific version of the platform and finally push on the docker hub repository,
+you can configure it with the command:
Review comment:
Thanks for suggestion.
##########
File path: assemblies/docker/build.sh
##########
@@ -21,11 +21,15 @@
usage() {
cat <<HERE
Usage:
- build.sh --from-local-dist [--archive <archive>] [--image-name <image>]
- build.sh --from-release --karaf-version <x.x.x> [--image-name <image>]
+ build.sh --from-local-dist [--archive <archive>] [--image-name <image>] [--build-multi-platform <string array of platform>]
+ build.sh --from-release --karaf-version <x.x.x> [--image-name <image>] [--build-multi-platform <string array of platform>]
Review comment:
Thanks for suggestion.
##########
File path: assemblies/docker/build.sh
##########
@@ -21,11 +21,15 @@
usage() {
cat <<HERE
Usage:
- build.sh --from-local-dist [--archive <archive>] [--image-name <image>]
- build.sh --from-release --karaf-version <x.x.x> [--image-name <image>]
+ build.sh --from-local-dist [--archive <archive>] [--image-name <image>] [--build-multi-platform <string array of platform>]
+ build.sh --from-release --karaf-version <x.x.x> [--image-name <image>] [--build-multi-platform <string array of platform>]
build.sh --help
If the --image-name flag is not used the built image name will be 'karaf'.
+ Check supported platform to build, you can verify with this command: docker buildx ls
+ The supported platform (OS/Arch) depend on image from build, in this case the
+ image is openjdk:8u212-jre-alpine https://hub.docker.com/_/openjdk?tab=tags&page=1&name=8u212-jre-alpine
Review comment:
Thanks for suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org