You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jackylee-ch (via GitHub)" <gi...@apache.org> on 2026/09/07 08:08:44 UTC
[PR] fix(storage-azdls): relative path is wrong for non-ASCII and spaces [iceberg-rust]
jackylee-ch opened a new pull request, #3163:
URL: https://github.com/apache/iceberg-rust/pull/3163
## Which issue does this PR close?
None — filed directly.
## What changes are included in this PR?
`AzureStoragePath::path` stored `Url::path()`, which is percent-encoded, while both consumers
recover the relative path by slicing that many bytes off the *raw* input string
(`azdls.rs` `azdls_create_operator`, and `lib.rs` `relativize_path`, used by `delete_stream`). Any
space or non-ASCII byte makes the encoded length longer than the input, so the offset lands inside
the host:
```
abfss://myfs@myaccount.dfs.core.windows.net/仓库/db/t/v1.json
was: .windows.net/仓库/db/t/v1.json
now: /仓库/db/t/v1.json
```
Reads then miss a blob that exists; writes create it under the mangled key while the manifest
records the correct `abfss://` URI. Keeping the raw substring fixes both consumers, so `lib.rs`
needs no change. `HfUri::parse` already derives its `path` from the raw input this way.
## Are these changes tested?
Yes — two cases added to `test_azdls_create_operator` (a non-ASCII segment and a space); both fail
on the parent commit. `cargo test --release -p iceberg-storage-opendal --lib --features
opendal-azdls` → 14 passed (13 before). With `--all-features`, `file_io_gcs_test` fails 4 tests with
`Connection refused` here and identically on unmodified `main` — it needs the docker fixture.
## AI Disclosure
Written with AI assistance (Claude Code); I reviewed the change and ran the tests above.
Note for reviewers: this backend still has no integration test, so the fix is covered by unit tests
only. I did not verify against a live ADLS account.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(storage-azdls): relative path is wrong for non-ASCII and spaces [iceberg-rust]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3163:
URL: https://github.com/apache/iceberg-rust/pull/3163#issuecomment-6205112228
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(storage-azdls): relative path is wrong for non-ASCII and spaces [iceberg-rust]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3163:
URL: https://github.com/apache/iceberg-rust/pull/3163#issuecomment-6049591563
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(storage-azdls): relative path is wrong for non-ASCII and spaces [iceberg-rust]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3163: fix(storage-azdls): relative path is wrong for non-ASCII and spaces
URL: https://github.com/apache/iceberg-rust/pull/3163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org