You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/02 13:40:08 UTC
[GitHub] [iotdb] ericpai opened a new pull request #5158: [IOTDB-2634] Fix batch script exit directly from cmd.exe
ericpai opened a new pull request #5158:
URL: https://github.com/apache/iotdb/pull/5158
See JIRA: https://issues.apache.org/jira/browse/IOTDB-2634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ericpai commented on pull request #5158: [IOTDB-2634] Fix batch script exit directly from cmd.exe
Posted by GitBox <gi...@apache.org>.
ericpai commented on pull request #5158:
URL: https://github.com/apache/iotdb/pull/5158#issuecomment-1057024553
It seems that the exit code is not as expected, I will check this later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou removed a comment on pull request #5158: [IOTDB-2634] Fix batch script exit directly from cmd.exe
Posted by GitBox <gi...@apache.org>.
HTHou removed a comment on pull request #5158:
URL: https://github.com/apache/iotdb/pull/5158#issuecomment-1057600535
> @HTHou I have tested both in cmd.exe and Powershell, they all only exit the .bat, not the terminal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ericpai commented on pull request #5158: [IOTDB-2634] Fix batch script exit directly from cmd.exe
Posted by GitBox <gi...@apache.org>.
ericpai commented on pull request #5158:
URL: https://github.com/apache/iotdb/pull/5158#issuecomment-1056943245
@HTHou PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou closed pull request #5158: [IOTDB-2634] Fix batch script exit directly from cmd.exe
Posted by GitBox <gi...@apache.org>.
HTHou closed pull request #5158:
URL: https://github.com/apache/iotdb/pull/5158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #5158: [IOTDB-2634] Fix batch script exit directly from cmd.exe
Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #5158:
URL: https://github.com/apache/iotdb/pull/5158#issuecomment-1057600535
> @HTHou I have tested both in cmd.exe and Powershell, they all only exit the .bat, not the terminal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #5158: [IOTDB-2634] Fix batch script exit directly from cmd.exe
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #5158:
URL: https://github.com/apache/iotdb/pull/5158#discussion_r817706687
##########
File path: cli/src/assembly/resources/tools/import-csv.bat
##########
@@ -57,4 +57,4 @@ pause
ENDLOCAL
-EXIT %ret_code%
+EXIT /B %ret_code%
Review comment:
Should we remove this line? We meet a problem because of it. When we try to import csv to iotdb, the cmd will close immediately after the csv imported….
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ericpai commented on pull request #5158: [IOTDB-2634] Fix batch script exit directly from cmd.exe
Posted by GitBox <gi...@apache.org>.
ericpai commented on pull request #5158:
URL: https://github.com/apache/iotdb/pull/5158#issuecomment-1057569660
@HTHou I have tested both in cmd.exe and Powershell, they all only exit the .bat, not the terminal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #5158: [IOTDB-2634] Fix batch script exit directly from cmd.exe
Posted by GitBox <gi...@apache.org>.
HTHou merged pull request #5158:
URL: https://github.com/apache/iotdb/pull/5158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org