Is it possible for reviewer to add other reviewers in the reviewboard?

[Sheng Yang <sh...@yasker.org>]

Or only submitter can modify it?

I find it would be useful if we identify the people who need to review it
after it's submitted.

--Sheng

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

[Daan Hoogland <da...@gmail.com>]

I'll have a quick look on rbtool.

I don't agree at all that more ASFBot noise should be produced. I'd like to
take the time to learn lua, but the dev channel is not inviting to me
because of it. I would propose to remove the present day message from it
instead. They get send to the mail list which is good enough, isn't it? Now
that we stopped #meeting , lets make sure discussion have all space
available on #dev...???

daan


On Thu, Jul 18, 2013 at 6:18 PM, Prasanna Santhanam <ts...@apache.org> wrote:

> On Thu, Jul 18, 2013 at 06:07:48PM +0200, Daan Hoogland wrote:
> > this has been kind of bugging me too. Along with unanswered questions on
> > teh list by newbees like me. As we all depend on volunteers and
> > conculeagues I don't really see a solution but reporting on outstanding
> > reviews and maybe unanswered questions. The latter can only be done
> > manually though, as it is really hard to automatically determine that a
> > mail requires reply. I kept track of the unanswered mails for one week
> > after ccc13. It were six that I didn't have time to gain knowledge to
> > answer. This is not extreme, but still may be a waste as some of the
> posing
> > people might have been thrown of the cloudstack track by them. Hugo said
> he
> > had a script querying the review board for old reviews and an automated
> > report on that would be easier. I know all you guru's do your best but a
> > weekly report, keeping us all conscious might help.
> >
> Yes - Rohit wrote the script and I send it sometimes before things
> like freeze/deadlines to alert the community but everyone's like ...
> meh.
>
> https://github.com/vogxn/RBTool (that's the tool)
>
> We should also have IRC alerts via ASFBot for every rb request posted
> and merged.  I was going to work on this with Humbeedoh (INFRA) but am
> yet to get to it. Feel free to pick it up - ASFBot is written in Lua.
>
> If you can't convince the people, try write tools around it eh?
>
>
> > As you might have guessed this is me volunteering to keep track of
> > unanswered questions for a few weeks. As we go along good ideas on how to
> > improve our way might spring up. /me is an optimist at rare occasions.
>
> I rant and go do the postive thing hoping for it to be picked up.
> Guess that makes me an optimist :)
>
> --
> Prasanna.,
>
> ------------------------
> Powered by BigRock.com
>
>

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

[Sheng Yang <sh...@yasker.org>]

We need some mechanism to help on review board. Sometime the people didn't
know who to ask for review and sometime committer push the code they didn't
familiar with.

I decided to spend much more time on reviewing code during 4.2 release
period, trying to make sure I would review everything on network part, and
also change reviewer(potentially follow up) to ensure the expert on the
certain area has a chance to take a look at the code before the patch
checked in.

Let's see how it would go...

--Sheng


On Thu, Jul 18, 2013 at 9:18 AM, Prasanna Santhanam <ts...@apache.org> wrote:

> On Thu, Jul 18, 2013 at 06:07:48PM +0200, Daan Hoogland wrote:
> > this has been kind of bugging me too. Along with unanswered questions on
> > teh list by newbees like me. As we all depend on volunteers and
> > conculeagues I don't really see a solution but reporting on outstanding
> > reviews and maybe unanswered questions. The latter can only be done
> > manually though, as it is really hard to automatically determine that a
> > mail requires reply. I kept track of the unanswered mails for one week
> > after ccc13. It were six that I didn't have time to gain knowledge to
> > answer. This is not extreme, but still may be a waste as some of the
> posing
> > people might have been thrown of the cloudstack track by them. Hugo said
> he
> > had a script querying the review board for old reviews and an automated
> > report on that would be easier. I know all you guru's do your best but a
> > weekly report, keeping us all conscious might help.
> >
> Yes - Rohit wrote the script and I send it sometimes before things
> like freeze/deadlines to alert the community but everyone's like ...
> meh.
>
> https://github.com/vogxn/RBTool (that's the tool)
>
> We should also have IRC alerts via ASFBot for every rb request posted
> and merged.  I was going to work on this with Humbeedoh (INFRA) but am
> yet to get to it. Feel free to pick it up - ASFBot is written in Lua.
>
> If you can't convince the people, try write tools around it eh?
>
>
> > As you might have guessed this is me volunteering to keep track of
> > unanswered questions for a few weeks. As we go along good ideas on how to
> > improve our way might spring up. /me is an optimist at rare occasions.
>
> I rant and go do the postive thing hoping for it to be picked up.
> Guess that makes me an optimist :)
>
> --
> Prasanna.,
>
> ------------------------
> Powered by BigRock.com
>
>

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

[Prasanna Santhanam <ts...@apache.org>]

On Thu, Jul 18, 2013 at 06:07:48PM +0200, Daan Hoogland wrote:
> this has been kind of bugging me too. Along with unanswered questions on
> teh list by newbees like me. As we all depend on volunteers and
> conculeagues I don't really see a solution but reporting on outstanding
> reviews and maybe unanswered questions. The latter can only be done
> manually though, as it is really hard to automatically determine that a
> mail requires reply. I kept track of the unanswered mails for one week
> after ccc13. It were six that I didn't have time to gain knowledge to
> answer. This is not extreme, but still may be a waste as some of the posing
> people might have been thrown of the cloudstack track by them. Hugo said he
> had a script querying the review board for old reviews and an automated
> report on that would be easier. I know all you guru's do your best but a
> weekly report, keeping us all conscious might help.
> 
Yes - Rohit wrote the script and I send it sometimes before things
like freeze/deadlines to alert the community but everyone's like ...
meh.

https://github.com/vogxn/RBTool (that's the tool)

We should also have IRC alerts via ASFBot for every rb request posted
and merged.  I was going to work on this with Humbeedoh (INFRA) but am
yet to get to it. Feel free to pick it up - ASFBot is written in Lua.

If you can't convince the people, try write tools around it eh?


> As you might have guessed this is me volunteering to keep track of
> unanswered questions for a few weeks. As we go along good ideas on how to
> improve our way might spring up. /me is an optimist at rare occasions.

I rant and go do the postive thing hoping for it to be picked up.
Guess that makes me an optimist :)

-- 
Prasanna.,

------------------------
Powered by BigRock.com

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

[Daan Hoogland <da...@gmail.com>]

this has been kind of bugging me too. Along with unanswered questions on
teh list by newbees like me. As we all depend on volunteers and
conculeagues I don't really see a solution but reporting on outstanding
reviews and maybe unanswered questions. The latter can only be done
manually though, as it is really hard to automatically determine that a
mail requires reply. I kept track of the unanswered mails for one week
after ccc13. It were six that I didn't have time to gain knowledge to
answer. This is not extreme, but still may be a waste as some of the posing
people might have been thrown of the cloudstack track by them. Hugo said he
had a script querying the review board for old reviews and an automated
report on that would be easier. I know all you guru's do your best but a
weekly report, keeping us all conscious might help.

As you might have guessed this is me volunteering to keep track of
unanswered questions for a few weeks. As we go along good ideas on how to
improve our way might spring up. /me is an optimist at rare occasions.

regards,
Daan


On Thu, Jul 18, 2013 at 5:43 PM, Chip Childers <ch...@sungard.com>wrote:

> So personally, I try my best to look at reviews whenever I have a spare
> moment.  That's not all that frequent, but if everyone did that we would
> be moving new code into the repo much more effectively and efficiently.
>
>
> On Thu, Jul 18, 2013 at 11:42:01AM +0530, Prasanna Santhanam wrote:
> > Yes and I've been doing it for months assigning reviewers, adding
> > comments. In some cases I've also added possible contributors who are
> > working in that area because committers are too "busy" to respond.
> >
> > Hate to be the pessimist around here but even upon adding reviewers I
> > don't see any response. So we likely don't really care for what
> > contributors are doing beyond our own silo of work. IF you like I can
> > pick out several reviews that have been sitting around for months with
> > no response from reviewers.
> >
> > It's unhealthy to say the least and I don't see adding reviewers to a
> > patch going to help if we don't change our attitude about pro-actively
> > reviewing areas of code that interest and/or break what we're working
> > on. Also I sense this power to assign reviewers is becoming like the
> > "Reply-To" thread where one doesnt respond until called-out for. I
> > hope it isn't
> >
> > When you see a new contributor the best boost they get from
> > contributing more and more is when the community cares/bothers to
> > review their work because they painfully worked on it. And that's
> > confirmation to the fact that their work is useful and welcome.
> > Committers more so should become "maintainers" like in the LKML
> > shepherding and mentoring new contributors to become committers so
> > they can leave behind their body of work and take this project to new
> > levels, adding robust architecture, features, making it more and more
> > solid and the best damn cloud orchestrator out there.
> >
> > On Wed, Jul 17, 2013 at 03:02:23PM -0700, Sheng Yang wrote:
> > > Or only submitter can modify it?
> > >
> > > I find it would be useful if we identify the people who need to review
> it
> > > after it's submitted.
> > >
> > > --Sheng
> >
> > --
> > Prasanna.,
> >
> > ------------------------
> > Powered by BigRock.com
> >
> >
>

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

[Chip Childers <ch...@sungard.com>]

So personally, I try my best to look at reviews whenever I have a spare
moment.  That's not all that frequent, but if everyone did that we would
be moving new code into the repo much more effectively and efficiently.


On Thu, Jul 18, 2013 at 11:42:01AM +0530, Prasanna Santhanam wrote:
> Yes and I've been doing it for months assigning reviewers, adding
> comments. In some cases I've also added possible contributors who are
> working in that area because committers are too "busy" to respond.
> 
> Hate to be the pessimist around here but even upon adding reviewers I
> don't see any response. So we likely don't really care for what
> contributors are doing beyond our own silo of work. IF you like I can
> pick out several reviews that have been sitting around for months with
> no response from reviewers.
> 
> It's unhealthy to say the least and I don't see adding reviewers to a
> patch going to help if we don't change our attitude about pro-actively
> reviewing areas of code that interest and/or break what we're working
> on. Also I sense this power to assign reviewers is becoming like the
> "Reply-To" thread where one doesnt respond until called-out for. I
> hope it isn't
> 
> When you see a new contributor the best boost they get from
> contributing more and more is when the community cares/bothers to
> review their work because they painfully worked on it. And that's
> confirmation to the fact that their work is useful and welcome.
> Committers more so should become "maintainers" like in the LKML
> shepherding and mentoring new contributors to become committers so
> they can leave behind their body of work and take this project to new
> levels, adding robust architecture, features, making it more and more
> solid and the best damn cloud orchestrator out there.
> 
> On Wed, Jul 17, 2013 at 03:02:23PM -0700, Sheng Yang wrote:
> > Or only submitter can modify it?
> > 
> > I find it would be useful if we identify the people who need to review it
> > after it's submitted.
> > 
> > --Sheng
> 
> -- 
> Prasanna.,
> 
> ------------------------
> Powered by BigRock.com
> 
> 

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

[Prasanna Santhanam <ts...@apache.org>]

Yes and I've been doing it for months assigning reviewers, adding
comments. In some cases I've also added possible contributors who are
working in that area because committers are too "busy" to respond.

Hate to be the pessimist around here but even upon adding reviewers I
don't see any response. So we likely don't really care for what
contributors are doing beyond our own silo of work. IF you like I can
pick out several reviews that have been sitting around for months with
no response from reviewers.

It's unhealthy to say the least and I don't see adding reviewers to a
patch going to help if we don't change our attitude about pro-actively
reviewing areas of code that interest and/or break what we're working
on. Also I sense this power to assign reviewers is becoming like the
"Reply-To" thread where one doesnt respond until called-out for. I
hope it isn't

When you see a new contributor the best boost they get from
contributing more and more is when the community cares/bothers to
review their work because they painfully worked on it. And that's
confirmation to the fact that their work is useful and welcome.
Committers more so should become "maintainers" like in the LKML
shepherding and mentoring new contributors to become committers so
they can leave behind their body of work and take this project to new
levels, adding robust architecture, features, making it more and more
solid and the best damn cloud orchestrator out there.

On Wed, Jul 17, 2013 at 03:02:23PM -0700, Sheng Yang wrote:
> Or only submitter can modify it?
> 
> I find it would be useful if we identify the people who need to review it
> after it's submitted.
> 
> --Sheng

-- 
Prasanna.,

------------------------
Powered by BigRock.com

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

[Sheng Yang <sh...@yasker.org>]

Created https://issues.apache.org/jira/browse/INFRA-6561

--Sheng


On Wed, Jul 17, 2013 at 3:06 PM, Chip Childers <ch...@sungard.com>wrote:

> Open an infra jira issue to get added permissions for reviewboard.
>
>
> On Wed, Jul 17, 2013 at 6:02 PM, Sheng Yang <sh...@yasker.org> wrote:
>
> > Or only submitter can modify it?
> >
> > I find it would be useful if we identify the people who need to review it
> > after it's submitted.
> >
> > --Sheng
> >
>

RE: Is it possible for reviewer to add other reviewers in the reviewboard?

[Animesh Chaturvedi <an...@citrix.com>]

Yes I also got the permission by opening up Infra ticket. The turnaround was quick too.

> -----Original Message-----
> From: Chip Childers [mailto:chip.childers@sungard.com]
> Sent: Wednesday, July 17, 2013 3:07 PM
> To: <de...@cloudstack.apache.org>
> Subject: Re: Is it possible for reviewer to add other reviewers in the
> reviewboard?
> 
> Open an infra jira issue to get added permissions for reviewboard.
> 
> 
> On Wed, Jul 17, 2013 at 6:02 PM, Sheng Yang <sh...@yasker.org> wrote:
> 
> > Or only submitter can modify it?
> >
> > I find it would be useful if we identify the people who need to review
> > it after it's submitted.
> >
> > --Sheng
> >

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

[Chip Childers <ch...@sungard.com>]

Open an infra jira issue to get added permissions for reviewboard.


On Wed, Jul 17, 2013 at 6:02 PM, Sheng Yang <sh...@yasker.org> wrote:

> Or only submitter can modify it?
>
> I find it would be useful if we identify the people who need to review it
> after it's submitted.
>
> --Sheng
>