[GitHub] [superset] dpgaspar commented on a change in pull request #15542: chore: add changed_on_delta_humanized field on dashboard schema

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #15542:
URL: https://github.com/apache/superset/pull/15542#discussion_r665478765



##########
File path: superset/dashboards/schemas.py
##########
@@ -159,6 +159,7 @@ class DashboardGetResponseSchema(Schema):
     owners = fields.List(fields.Nested(UserSchema))
     roles = fields.List(fields.Nested(RolesSchema))
     table_names = fields.String()  # legacy nonsense
+    changed_on_humanized = fields.String(data_key="changed_on_delta_humanized")

Review comment:
       to ensure 2. we should add show_columns = list_columns on the REST API class, and follow the same existing pattern




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org