You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/07 08:26:39 UTC
[GitHub] [kafka] satishd opened a new pull request #10647: MINOR Removed copying storage libraries specifically as the task already copies them.
satishd opened a new pull request #10647:
URL: https://github.com/apache/kafka/pull/10647
- Removed copying storage libraries specifically as the task already copies them.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] satishd commented on pull request #10647: MINOR Removed copying storage libraries specifically as the task already copies them.
Posted by GitBox <gi...@apache.org>.
satishd commented on pull request #10647:
URL: https://github.com/apache/kafka/pull/10647#issuecomment-834250531
@junrao It is a minor change as you pointed out [here](https://github.com/apache/kafka/pull/10638#discussion_r627630009). Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] junrao merged pull request #10647: MINOR Removed copying storage libraries specifically as the task already copies them.
Posted by GitBox <gi...@apache.org>.
junrao merged pull request #10647:
URL: https://github.com/apache/kafka/pull/10647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] satishd edited a comment on pull request #10647: MINOR Removed copying storage libraries specifically as the task already copies them.
Posted by GitBox <gi...@apache.org>.
satishd edited a comment on pull request #10647:
URL: https://github.com/apache/kafka/pull/10647#issuecomment-834250531
@junrao It is a minor change to address the issue you mentioned [here](https://github.com/apache/kafka/pull/10638#discussion_r627630009). Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #10647: MINOR Removed copying storage libraries specifically as the task already copies them.
Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #10647:
URL: https://github.com/apache/kafka/pull/10647#discussion_r628218197
##########
File path: build.gradle
##########
@@ -1003,10 +1003,6 @@ project(':core') {
from(project(':connect:mirror').configurations.runtimeClasspath) { into("libs/") }
from(project(':connect:mirror-client').jar) { into("libs/") }
from(project(':connect:mirror-client').configurations.runtimeClasspath) { into("libs/") }
- from(project(':storage').jar) { into("libs/") }
- from(project(':storage').configurations.runtimeClasspath) { into("libs/") }
- from(project(':storage:api').jar) { into("libs/") }
- from(project(':storage:api').configurations.runtimeClasspath) { into("libs/") }
Review comment:
Can you clarify why this is not needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #10647: MINOR Removed copying storage libraries specifically as the task already copies them.
Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #10647:
URL: https://github.com/apache/kafka/pull/10647#discussion_r630330236
##########
File path: build.gradle
##########
@@ -1003,10 +1003,6 @@ project(':core') {
from(project(':connect:mirror').configurations.runtimeClasspath) { into("libs/") }
from(project(':connect:mirror-client').jar) { into("libs/") }
from(project(':connect:mirror-client').configurations.runtimeClasspath) { into("libs/") }
- from(project(':storage').jar) { into("libs/") }
- from(project(':storage').configurations.runtimeClasspath) { into("libs/") }
- from(project(':storage:api').jar) { into("libs/") }
- from(project(':storage:api').configurations.runtimeClasspath) { into("libs/") }
Review comment:
Makes sense, we only need to add modules that are not a core dependency already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] satishd commented on a change in pull request #10647: MINOR Removed copying storage libraries specifically as the task already copies them.
Posted by GitBox <gi...@apache.org>.
satishd commented on a change in pull request #10647:
URL: https://github.com/apache/kafka/pull/10647#discussion_r628359445
##########
File path: build.gradle
##########
@@ -1003,10 +1003,6 @@ project(':core') {
from(project(':connect:mirror').configurations.runtimeClasspath) { into("libs/") }
from(project(':connect:mirror-client').jar) { into("libs/") }
from(project(':connect:mirror-client').configurations.runtimeClasspath) { into("libs/") }
- from(project(':storage').jar) { into("libs/") }
- from(project(':storage').configurations.runtimeClasspath) { into("libs/") }
- from(project(':storage:api').jar) { into("libs/") }
- from(project(':storage:api').configurations.runtimeClasspath) { into("libs/") }
Review comment:
I observed that these libraries are copied as mentioned [here](https://github.com/apache/kafka/pull/10647/commits/1ad50e8634d56622e58a50c8328205b6db3f528d#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7R981).
```
from(configurations.runtimeClasspath) { into("libs/") }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org