You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Konstantin Kolinko <kn...@gmail.com> on 2009/12/24 13:20:59 UTC
Re: svn commit: r893731 - in /tomcat/trunk: ./ java/org/apache/catalina/core/
java/org/apache/catalina/startup/ java/org/apache/jasper/compiler/
java/org/apache/tomcat/util/scan/ res/maven/
2009/12/24 <ma...@apache.org>:
> Author: markt
> Date: Thu Dec 24 11:14:46 2009
> New Revision: 893731
>
> URL: http://svn.apache.org/viewvc?rev=893731&view=rev
> Log:
> Move JAR scanning into a new JAR used by both Catalina and Jasper
>
> +++ tomcat/trunk/java/org/apache/tomcat/util/scan/DefaultJarScanner.java Thu Dec 24 11:14:46 2009
> @@ -15,7 +15,7 @@
> * limitations under the License.
> */
>
> -package org.apache.catalina.startup;
> +package org.apache.tomcat.util.scan;
>
>(...)
>
> +import org.apache.catalina.startup.Constants;
> import org.apache.juli.logging.Log;
> import org.apache.juli.logging.LogFactory;
> import org.apache.tomcat.JarScanner;
> @@ -48,8 +49,6 @@
> * (disabled by default)</li>
> * </ul>
> * All of the extensions may be controlled via configuration.
> - *
> - * Keep in sync with org.apache.jasper.compiler.InternalJarScanner
> */
> public class DefaultJarScanner implements JarScanner {
>
>
> +import org.apache.catalina.startup.Constants;
Dependency on Catalina.
/**
* The string resources for this package.
*/
private static final StringManager sm =
StringManager.getManager(Constants.Package);
The string resources used by DefaultJarScanner have to be moved to
the new package as well.
Maybe you already have that in mind. It is just a reminder.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r893731 - in /tomcat/trunk: ./ java/org/apache/catalina/core/
java/org/apache/catalina/startup/ java/org/apache/jasper/compiler/ java/org/apache/tomcat/util/scan/
res/maven/
Posted by Mark Thomas <ma...@apache.org>.
On 24/12/2009 12:20, Konstantin Kolinko wrote:
> 2009/12/24 <ma...@apache.org>:
>> Author: markt
>> Date: Thu Dec 24 11:14:46 2009
>> New Revision: 893731
>>
>> URL: http://svn.apache.org/viewvc?rev=893731&view=rev
>> Log:
>> Move JAR scanning into a new JAR used by both Catalina and Jasper
>>
>
>> +++ tomcat/trunk/java/org/apache/tomcat/util/scan/DefaultJarScanner.java Thu Dec 24 11:14:46 2009
>> @@ -15,7 +15,7 @@
>> * limitations under the License.
>> */
>>
>> -package org.apache.catalina.startup;
>> +package org.apache.tomcat.util.scan;
>>
>> (...)
>>
>> +import org.apache.catalina.startup.Constants;
>> import org.apache.juli.logging.Log;
>> import org.apache.juli.logging.LogFactory;
>> import org.apache.tomcat.JarScanner;
>> @@ -48,8 +49,6 @@
>> * (disabled by default)</li>
>> * </ul>
>> * All of the extensions may be controlled via configuration.
>> - *
>> - * Keep in sync with org.apache.jasper.compiler.InternalJarScanner
>> */
>> public class DefaultJarScanner implements JarScanner {
>>
>>
>
>
>> +import org.apache.catalina.startup.Constants;
>
> Dependency on Catalina.
>
> /**
> * The string resources for this package.
> */
> private static final StringManager sm =
> StringManager.getManager(Constants.Package);
>
> The string resources used by DefaultJarScanner have to be moved to
> the new package as well.
>
> Maybe you already have that in mind. It is just a reminder.
Thanks for the reminder. It is on the todo list but as part of a wider
effort to have a single StringManager implementation. That means
including StringManager in the tomcat-util JAR. I'll be doing that later
today.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org