You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Brenden Matthews <br...@diddyinc.com> on 2013/05/14 02:20:57 UTC

Review Request: Turn down noise from ZooKeeper.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11127/
-----------------------------------------------------------

Review request for mesos.


Description
-------

>From 1206c6234fb83014c66c249d96caa8f6c4190f29 Mon Sep 17 00:00:00 2001
From: Brenden Matthews <br...@airbnb.com>
Date: Sun, 5 May 2013 10:48:06 -0700
Subject: [PATCH 20/24] Turn down noise from ZooKeeper.

Review: https://reviews.apache.org/r/11127
---
 src/detector/detector.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Diffs
-----

  src/detector/detector.cpp 12deefa0b9df3f4946d80f500caaa5199b8ea28e 

Diff: https://reviews.apache.org/r/11127/diff/


Testing
-------

Used in production at airbnb.


Thanks,

Brenden Matthews


Re: Review Request: Turn down noise from ZooKeeper.

Posted by Brenden Matthews <br...@diddyinc.com>.

> On May 17, 2013, 7:25 p.m., Vinod Kone wrote:
> > src/detector/detector.cpp, line 204
> > <https://reviews.apache.org/r/11127/diff/2/?file=291861#file291861line204>
> >
> >     woah! why do you want to take away this option from users?

I wanted to disable the noise from zookeeper but keep everything else.  I don't see a way to do that.  I'll discard this for now.


- Brenden


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11127/#review20720
-----------------------------------------------------------


On May 14, 2013, 5:57 p.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11127/
> -----------------------------------------------------------
> 
> (Updated May 14, 2013, 5:57 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> From 1206c6234fb83014c66c249d96caa8f6c4190f29 Mon Sep 17 00:00:00 2001
> From: Brenden Matthews <br...@airbnb.com>
> Date: Sun, 5 May 2013 10:48:06 -0700
> Subject: [PATCH 20/24] Turn down noise from ZooKeeper.
> 
> Review: https://reviews.apache.org/r/11127
> ---
>  src/detector/detector.cpp |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Diffs
> -----
> 
>   src/detector/detector.cpp 12deefa0b9df3f4946d80f500caaa5199b8ea28e 
> 
> Diff: https://reviews.apache.org/r/11127/diff/
> 
> 
> Testing
> -------
> 
> Used in production at airbnb.
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Re: Review Request: Turn down noise from ZooKeeper.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11127/#review20720
-----------------------------------------------------------



src/detector/detector.cpp
<https://reviews.apache.org/r/11127/#comment42787>

    woah! why do you want to take away this option from users?


- Vinod Kone


On May 14, 2013, 5:57 p.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11127/
> -----------------------------------------------------------
> 
> (Updated May 14, 2013, 5:57 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> From 1206c6234fb83014c66c249d96caa8f6c4190f29 Mon Sep 17 00:00:00 2001
> From: Brenden Matthews <br...@airbnb.com>
> Date: Sun, 5 May 2013 10:48:06 -0700
> Subject: [PATCH 20/24] Turn down noise from ZooKeeper.
> 
> Review: https://reviews.apache.org/r/11127
> ---
>  src/detector/detector.cpp |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Diffs
> -----
> 
>   src/detector/detector.cpp 12deefa0b9df3f4946d80f500caaa5199b8ea28e 
> 
> Diff: https://reviews.apache.org/r/11127/diff/
> 
> 
> Testing
> -------
> 
> Used in production at airbnb.
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Re: Review Request: Turn down noise from ZooKeeper.

Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11127/
-----------------------------------------------------------

(Updated May 14, 2013, 5:57 p.m.)


Review request for mesos.


Description
-------

>From 1206c6234fb83014c66c249d96caa8f6c4190f29 Mon Sep 17 00:00:00 2001
From: Brenden Matthews <br...@airbnb.com>
Date: Sun, 5 May 2013 10:48:06 -0700
Subject: [PATCH 20/24] Turn down noise from ZooKeeper.

Review: https://reviews.apache.org/r/11127
---
 src/detector/detector.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Diffs (updated)
-----

  src/detector/detector.cpp 12deefa0b9df3f4946d80f500caaa5199b8ea28e 

Diff: https://reviews.apache.org/r/11127/diff/


Testing
-------

Used in production at airbnb.


Thanks,

Brenden Matthews