You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "zhangshenghang (via GitHub)" <gi...@apache.org> on 2026/01/05 15:05:21 UTC
Re: [PR] [Fix][Connector-V2] Fix partitioning column selection logic [seatunnel]
zhangshenghang commented on code in PR #10236:
URL: https://github.com/apache/seatunnel/pull/10236#discussion_r2661814742
##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/base/source/enumerator/splitter/AbstractJdbcSourceChunkSplitter.java:
##########
@@ -429,15 +429,11 @@ protected Column getSplitColumn(
Optional<PrimaryKey> primaryKey = dialect.getPrimaryKey(jdbc, tableId);
if (primaryKey.isPresent()) {
- List<String> pkColumns = primaryKey.get().getColumnNames();
-
- for (String pkColumn : pkColumns) {
- Column column = table.columnWithName(pkColumn);
- if (isEvenlySplitColumn(column)) {
- splitColumn = columnComparable(splitColumn, column);
- if (sqlTypePriority(splitColumn) == 1) {
- return splitColumn;
- }
+ Column firstColumn = table.columnWithName(primaryKey.get().getColumnNames().get(0));
+ if (isEvenlySplitColumn(firstColumn)) {
+ splitColumn = columnComparable(splitColumn, firstColumn);
+ if (sqlTypePriority(splitColumn) == 1) {
+ return splitColumn;
Review Comment:
How about printing a log after selecting the column, so that users can know some details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org