You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/03/22 03:35:02 UTC

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #9740: Add the SQL definition ALTER SYNONYM of Oracle database

tristaZero commented on a change in pull request #9740:
URL: https://github.com/apache/shardingsphere/pull/9740#discussion_r598405448



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/ddl/DDLStatementAssert.java
##########
@@ -72,6 +75,8 @@ public static void assertIs(final SQLCaseAssertContext assertContext, final DDLS
             AlterIndexStatementAssert.assertIs(assertContext, (AlterIndexStatement) actual, (AlterIndexStatementTestCase) expected);
         } else if (actual instanceof DropIndexStatement) {
             DropIndexStatementAssert.assertIs(assertContext, (DropIndexStatement) actual, (DropIndexStatementTestCase) expected);
+        } else if (actual instanceof OracleAlterSynonymStatement) {

Review comment:
       Hi sorry for my late comment.
   Is `AlterSynonym` similar with `AlterTable`? 
   If so, OracleAlterSynonymStatement is needed, I suppose.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org