You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/13 14:51:59 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #12497: fix: list filters vertical alignment
michael-s-molina opened a new pull request #12497:
URL: https://github.com/apache/superset/pull/12497
### SUMMARY
Fix list filters vertical alignment.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="783" alt="Screen Shot 2021-01-13 at 11 36 42 AM" src="https://user-images.githubusercontent.com/70410625/104467223-d90d9980-5594-11eb-89fb-8dfa84368d4f.png">
<img width="794" alt="Screen Shot 2021-01-13 at 11 42 28 AM" src="https://user-images.githubusercontent.com/70410625/104467244-df9c1100-5594-11eb-8125-91816317925e.png">
### TEST PLAN
1 - Go to main lists (databases, datasets, charts and dashboards)
2 - All filters labels should be vertically aligned with values
@junlincc
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas edited a comment on pull request #12497: fix: list filters vertical alignment
Posted by GitBox <gi...@apache.org>.
rusackas edited a comment on pull request #12497:
URL: https://github.com/apache/superset/pull/12497#issuecomment-759673730
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina edited a comment on pull request #12497: fix: list filters vertical alignment
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on pull request #12497:
URL: https://github.com/apache/superset/pull/12497#issuecomment-759656366
Hey @willbarrett you're absolutely right! Thanks for the eagle eyes! I'll fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #12497: fix: list filters vertical alignment
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #12497:
URL: https://github.com/apache/superset/pull/12497
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #12497: fix: list filters vertical alignment
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #12497:
URL: https://github.com/apache/superset/pull/12497#issuecomment-759687111
@rusackas Applied your suggestion. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12497: fix: list filters vertical alignment
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12497:
URL: https://github.com/apache/superset/pull/12497#issuecomment-759636946
# [Codecov](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=h1) Report
> Merging [#12497](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=desc) (bd69d55) into [master](https://codecov.io/gh/apache/superset/commit/7aba4c246aa716ce11a0e866fcd8190b9448c727?el=desc) (7aba4c2) will **decrease** coverage by `2.48%`.
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12497 +/- ##
==========================================
- Coverage 66.29% 63.81% -2.49%
==========================================
Files 1015 486 -529
Lines 49554 29964 -19590
Branches 5079 0 -5079
==========================================
- Hits 32854 19122 -13732
+ Misses 16562 10842 -5720
+ Partials 138 0 -138
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.81% <81.81%> (-0.28%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `99.45% <ø> (-0.55%)` | :arrow_down: |
| [superset/db\_engine\_specs/druid.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RydWlkLnB5) | `88.63% <33.33%> (+27.27%)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `86.84% <89.47%> (+0.87%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `89.39% <0.00%> (-5.61%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| ... and [544 more](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=footer). Last update [40a334a...bd69d55](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #12497: fix: list filters vertical alignment
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #12497:
URL: https://github.com/apache/superset/pull/12497#issuecomment-759755834
LGTM, but @nytai owns this so I'll let him 👀 & ✅ & 🔀
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12497: fix: list filters vertical alignment
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12497:
URL: https://github.com/apache/superset/pull/12497#issuecomment-759636946
# [Codecov](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=h1) Report
> Merging [#12497](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=desc) (4fc2346) into [master](https://codecov.io/gh/apache/superset/commit/7aba4c246aa716ce11a0e866fcd8190b9448c727?el=desc) (7aba4c2) will **decrease** coverage by `2.91%`.
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12497 +/- ##
==========================================
- Coverage 66.29% 63.38% -2.92%
==========================================
Files 1015 486 -529
Lines 49554 29925 -19629
Branches 5079 0 -5079
==========================================
- Hits 32854 18967 -13887
+ Misses 16562 10958 -5604
+ Partials 138 0 -138
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.38% <81.81%> (-0.71%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `99.45% <ø> (-0.55%)` | :arrow_down: |
| [superset/db\_engine\_specs/druid.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RydWlkLnB5) | `88.63% <33.33%> (+27.27%)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `86.84% <89.47%> (+0.87%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [551 more](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=footer). Last update [40a334a...4fc2346](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12497: fix: list filters vertical alignment
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12497:
URL: https://github.com/apache/superset/pull/12497#issuecomment-759764319
let's get this one in for rc3. current state looks bad.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] willbarrett commented on pull request #12497: fix: list filters vertical alignment
Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #12497:
URL: https://github.com/apache/superset/pull/12497#issuecomment-759654496
Hey @michael-s-molina this still looks a pixel low. Better than before though! Happy to merge as-is if there's an issue bumping that 1 more pixel up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12497: fix: list filters vertical alignment
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12497:
URL: https://github.com/apache/superset/pull/12497#issuecomment-759636946
# [Codecov](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=h1) Report
> Merging [#12497](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=desc) (bd69d55) into [master](https://codecov.io/gh/apache/superset/commit/7aba4c246aa716ce11a0e866fcd8190b9448c727?el=desc) (7aba4c2) will **decrease** coverage by `2.48%`.
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12497 +/- ##
==========================================
- Coverage 66.29% 63.81% -2.49%
==========================================
Files 1015 486 -529
Lines 49554 29964 -19590
Branches 5079 0 -5079
==========================================
- Hits 32854 19122 -13732
+ Misses 16562 10842 -5720
+ Partials 138 0 -138
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.81% <81.81%> (-0.28%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `99.45% <ø> (-0.55%)` | :arrow_down: |
| [superset/db\_engine\_specs/druid.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RydWlkLnB5) | `88.63% <33.33%> (+27.27%)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `86.84% <89.47%> (+0.87%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `89.39% <0.00%> (-5.61%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| ... and [544 more](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=footer). Last update [40a334a...bd69d55](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12497: fix: list filters vertical alignment
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12497:
URL: https://github.com/apache/superset/pull/12497#issuecomment-759636946
# [Codecov](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=h1) Report
> Merging [#12497](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=desc) (bd69d55) into [master](https://codecov.io/gh/apache/superset/commit/7aba4c246aa716ce11a0e866fcd8190b9448c727?el=desc) (7aba4c2) will **decrease** coverage by `7.11%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12497 +/- ##
==========================================
- Coverage 66.29% 59.17% -7.12%
==========================================
Files 1015 959 -56
Lines 49554 46832 -2722
Branches 5079 4344 -735
==========================================
- Hits 32854 27715 -5139
- Misses 16562 19117 +2555
+ Partials 138 0 -138
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.94% <0.00%> (+3.83%)` | :arrow_up: |
| javascript | `?` | |
| python | `63.81% <81.81%> (-0.28%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...t-frontend/src/components/ListView/Filters/Base.ts](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy9CYXNlLnRz) | `100.00% <ø> (ø)` | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `68.96% <0.00%> (+12.63%)` | :arrow_up: |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `99.45% <ø> (-0.55%)` | :arrow_down: |
| [superset/db\_engine\_specs/druid.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RydWlkLnB5) | `88.63% <33.33%> (+27.27%)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `86.84% <89.47%> (+0.87%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| ... and [419 more](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=footer). Last update [40a334a...bd69d55](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12497: fix: list filters vertical alignment
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12497:
URL: https://github.com/apache/superset/pull/12497#issuecomment-759636946
# [Codecov](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=h1) Report
> Merging [#12497](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=desc) (4fc2346) into [master](https://codecov.io/gh/apache/superset/commit/7aba4c246aa716ce11a0e866fcd8190b9448c727?el=desc) (7aba4c2) will **decrease** coverage by `2.92%`.
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12497 +/- ##
==========================================
- Coverage 66.29% 63.37% -2.93%
==========================================
Files 1015 486 -529
Lines 49554 29940 -19614
Branches 5079 0 -5079
==========================================
- Hits 32854 18974 -13880
+ Misses 16562 10966 -5596
+ Partials 138 0 -138
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.37% <81.81%> (-0.72%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `99.45% <ø> (-0.55%)` | :arrow_down: |
| [superset/db\_engine\_specs/druid.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RydWlkLnB5) | `88.63% <33.33%> (+27.27%)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `86.84% <89.47%> (+0.87%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [544 more](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=footer). Last update [40a334a...4fc2346](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina edited a comment on pull request #12497: fix: list filters vertical alignment
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on pull request #12497:
URL: https://github.com/apache/superset/pull/12497#issuecomment-759656366
Hey @willbarrett you're absolutely right! Thanks for the eagle eyes! I'll fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12497: fix: list filters vertical alignment
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12497:
URL: https://github.com/apache/superset/pull/12497#issuecomment-759636946
# [Codecov](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=h1) Report
> Merging [#12497](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=desc) (bd69d55) into [master](https://codecov.io/gh/apache/superset/commit/7aba4c246aa716ce11a0e866fcd8190b9448c727?el=desc) (7aba4c2) will **decrease** coverage by `2.98%`.
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12497 +/- ##
==========================================
- Coverage 66.29% 63.31% -2.99%
==========================================
Files 1015 486 -529
Lines 49554 29962 -19592
Branches 5079 0 -5079
==========================================
- Hits 32854 18971 -13883
+ Misses 16562 10991 -5571
+ Partials 138 0 -138
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.31% <81.81%> (-0.78%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `99.45% <ø> (-0.55%)` | :arrow_down: |
| [superset/db\_engine\_specs/druid.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RydWlkLnB5) | `88.63% <33.33%> (+27.27%)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `86.84% <89.47%> (+0.87%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [548 more](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=footer). Last update [40a334a...bd69d55](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12497: fix: list filters vertical alignment
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12497:
URL: https://github.com/apache/superset/pull/12497#issuecomment-759636946
# [Codecov](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=h1) Report
> Merging [#12497](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=desc) (bd69d55) into [master](https://codecov.io/gh/apache/superset/commit/7aba4c246aa716ce11a0e866fcd8190b9448c727?el=desc) (7aba4c2) will **decrease** coverage by `7.25%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12497 +/- ##
==========================================
- Coverage 66.29% 59.04% -7.26%
==========================================
Files 1015 959 -56
Lines 49554 46832 -2722
Branches 5079 4344 -735
==========================================
- Hits 32854 27651 -5203
- Misses 16562 19181 +2619
+ Partials 138 0 -138
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.56% <0.00%> (+3.45%)` | :arrow_up: |
| javascript | `?` | |
| python | `63.81% <81.81%> (-0.28%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...t-frontend/src/components/ListView/Filters/Base.ts](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy9CYXNlLnRz) | `100.00% <ø> (ø)` | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `68.96% <0.00%> (+12.63%)` | :arrow_up: |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `99.45% <ø> (-0.55%)` | :arrow_down: |
| [superset/db\_engine\_specs/druid.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RydWlkLnB5) | `88.63% <33.33%> (+27.27%)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `86.84% <89.47%> (+0.87%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| ... and [419 more](https://codecov.io/gh/apache/superset/pull/12497/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=footer). Last update [40a334a...bd69d55](https://codecov.io/gh/apache/superset/pull/12497?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #12497: fix: list filters vertical alignment
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #12497:
URL: https://github.com/apache/superset/pull/12497#issuecomment-759656366
Hey @willbarrett you're absolute right! Thanks for the eagle eyes! I'll fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas edited a comment on pull request #12497: fix: list filters vertical alignment
Posted by GitBox <gi...@apache.org>.
rusackas edited a comment on pull request #12497:
URL: https://github.com/apache/superset/pull/12497#issuecomment-759673730
@michael-s-molina I see another route to fixing this that may make sense.
In `Base.ts` add `align-items` to `FilterContainer`, i.e.:
```
export const FilterContainer = styled.div`
display: inline-flex;
margin-right: 2em;
font-size: ${({ theme }) => theme.typography.sizes.s}px;
align-items: center;
`;
```
... and in `FilterTitle` remove the `line-height`, i.e.:
```
export const FilterTitle = styled.label`
font-weight: bold;
margin: 0 0.4em 0 0;
`;
```
then you should come out clean without having to nudge any pixels around.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #12497: fix: list filters vertical alignment
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #12497:
URL: https://github.com/apache/superset/pull/12497#issuecomment-759673730
@michael-s-molina I see another route to fixing this that may make sense. Just have to track down the `styled` instances, since Emotion source maps still aren't working :P
In `Base.ts` add `align-items` to `FilterContainer`, i.e.:
```
export const FilterContainer = styled.div`
display: inline-flex;
margin-right: 2em;
font-size: ${({ theme }) => theme.typography.sizes.s}px;
align-items: center;
`;
```
... and in `FilterTitle` remove the `line-height`, i.e.:
```
font-weight: bold;
margin: 0 0.4em 0 0;
`;
```
then you should come out clean without having to nudge any pixels around.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas edited a comment on pull request #12497: fix: list filters vertical alignment
Posted by GitBox <gi...@apache.org>.
rusackas edited a comment on pull request #12497:
URL: https://github.com/apache/superset/pull/12497#issuecomment-759673730
@michael-s-molina I see another route to fixing this that may make sense.
In `Base.ts` add `align-items` to `FilterContainer`, i.e.:
```
export const FilterContainer = styled.div`
display: inline-flex;
margin-right: 2em;
font-size: ${({ theme }) => theme.typography.sizes.s}px;
align-items: center;
`;
```
... and in `FilterTitle` remove the `line-height`, i.e.:
```
export const FilterTitle = styled.label`
font-weight: bold;
margin: 0 0.4em 0 0;
`;
```
then you should come out clean without having to nudge any pixels around.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org