You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/25 09:11:39 UTC

[GitHub] [apisix] spacewander commented on a change in pull request #2311: fix: redirect is not correct

spacewander commented on a change in pull request #2311:
URL: https://github.com/apache/apisix/pull/2311#discussion_r494855035



##########
File path: apisix/plugins/redirect.lua
##########
@@ -133,7 +135,11 @@ function _M.rewrite(conf, ctx)
         -- TODO： add test case
         -- PR: https://github.com/apache/apisix/pull/1958
         uri = "https://$host$request_uri"
-        ret_code = 301
+        if ngx.req.get_method() == http_post then

Review comment:
       I think it would be better to use whitelist (`GET` OR `HEAD`) instead.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org