You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Jonathan Moore (JIRA)" <ji...@apache.org> on 2010/09/02 16:39:54 UTC

[jira] Created: (HTTPCLIENT-985) cache module should populate Via header to capture upstream and downstream protocols

cache module should populate Via header to capture upstream and downstream protocols
------------------------------------------------------------------------------------

                 Key: HTTPCLIENT-985
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-985
             Project: HttpComponents HttpClient
          Issue Type: Bug
          Components: Cache
    Affects Versions: 4.1 Alpha2
            Reporter: Jonathan Moore


Because the cache module is currently implemented as a decorator that behaves like a transparent caching proxy, we need it to correctly populate the Via header so that we can preserve the record of which protocol versions were used upstream and downstream from the caching module.

http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.45

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Updated: (HTTPCLIENT-985) cache module should populate Via header to capture upstream and downstream protocols

Posted by "Jonathan Moore (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Moore updated HTTPCLIENT-985:
--------------------------------------

    Description: 
Because the cache module is currently implemented as a decorator that behaves like a transparent caching proxy, we need it to correctly populate the Via header so that we can preserve the record of which protocol versions were used upstream and downstream from the caching module.

This is a MUST per the RFC:
http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.45

  was:
Because the cache module is currently implemented as a decorator that behaves like a transparent caching proxy, we need it to correctly populate the Via header so that we can preserve the record of which protocol versions were used upstream and downstream from the caching module.

http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.45


> cache module should populate Via header to capture upstream and downstream protocols
> ------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-985
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-985
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 4.1 Alpha2
>            Reporter: Jonathan Moore
>
> Because the cache module is currently implemented as a decorator that behaves like a transparent caching proxy, we need it to correctly populate the Via header so that we can preserve the record of which protocol versions were used upstream and downstream from the caching module.
> This is a MUST per the RFC:
> http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.45

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Updated: (HTTPCLIENT-985) cache module should populate Via header to capture upstream and downstream protocols

Posted by "Jonathan Moore (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Moore updated HTTPCLIENT-985:
--------------------------------------

    Attachment: via-header.patch

I've uploaded a patch that fixes this issue, including unit tests. One area for discussion is how to populate the comment section of the Via header (if we want to include one). Currently the implementation follows the format of the User-Agent set by DefaultHttpClient, so:

Via: 1.1 localhost (Apache-HttpClient/4.1-alpha3-SNAPSHOT (cache))

This patch is contributed with the permission of my employer.

> cache module should populate Via header to capture upstream and downstream protocols
> ------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-985
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-985
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 4.1 Alpha2
>            Reporter: Jonathan Moore
>         Attachments: via-header.patch
>
>
> Because the cache module is currently implemented as a decorator that behaves like a transparent caching proxy, we need it to correctly populate the Via header so that we can preserve the record of which protocol versions were used upstream and downstream from the caching module.
> This is a MUST per the RFC:
> http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.45

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Resolved: (HTTPCLIENT-985) cache module should populate Via header to capture upstream and downstream protocols

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-985.
------------------------------------------

    Fix Version/s: 4.1 Alpha3
       Resolution: Fixed

Patch checked in. Many thanks, Jon

Oleg

> cache module should populate Via header to capture upstream and downstream protocols
> ------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-985
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-985
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 4.1 Alpha2
>            Reporter: Jonathan Moore
>             Fix For: 4.1 Alpha3
>
>         Attachments: via-header.patch
>
>
> Because the cache module is currently implemented as a decorator that behaves like a transparent caching proxy, we need it to correctly populate the Via header so that we can preserve the record of which protocol versions were used upstream and downstream from the caching module.
> This is a MUST per the RFC:
> http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.45

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org