You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2023/01/06 09:43:53 UTC

[GitHub] [rocketmq] cserwen opened a new issue, #5838: Client will not retry to send message when broker busy

cserwen opened a new issue, #5838:
URL: https://github.com/apache/rocketmq/issues/5838

   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   Client will retry when server returns the following code:
   ![image](https://user-images.githubusercontent.com/46882838/210973503-4fbc640d-d042-4546-94d0-18dc41e5f43d.png)
   
   But some code of broker-busy is `SYSTEM_BUSY`, the client will stop to retry. Broker's glitch will cause the client to stop retrying, resulting in sending failure. If it can retry to other Broker nodes, this problem can be avoided.
   
   2. Please tell us about your environment:
   
   3. Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Client will not retry to send message when broker busy [rocketmq]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #5838:
URL: https://github.com/apache/rocketmq/issues/5838#issuecomment-1885959482

   This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] cserwen commented on issue #5838: Client will not retry to send message when broker busy

Posted by GitBox <gi...@apache.org>.
cserwen commented on issue #5838:
URL: https://github.com/apache/rocketmq/issues/5838#issuecomment-1375034674

   As for order messages, the retry logic of SDK has already considered this scenario, so there is no need to worry about it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] fuyou001 commented on issue #5838: Client will not retry to send message when broker busy

Posted by GitBox <gi...@apache.org>.
fuyou001 commented on issue #5838:
URL: https://github.com/apache/rocketmq/issues/5838#issuecomment-1374986946

   In most case, when broker return  SYSTEM_BUSY error   code ,means  brokers can't process more request,so sdk can't retry


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] cserwen commented on issue #5838: Client will not retry to send message when broker busy

Posted by GitBox <gi...@apache.org>.
cserwen commented on issue #5838:
URL: https://github.com/apache/rocketmq/issues/5838#issuecomment-1375033267

   IMO,SYSTEM_BUSY only meas current broker can't process so many requests, but other broker is ok. If it will retry in this case, the client will not fail to send and users will not see this error. @fuyou001 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] ni-ze commented on issue #5838: Client will not retry to send message when broker busy

Posted by GitBox <gi...@apache.org>.
ni-ze commented on issue #5838:
URL: https://github.com/apache/rocketmq/issues/5838#issuecomment-1376608015

   IMO, It is ok to retry when the error code is SYSTEM_BUSY, the commercial version does retry when the return is SYSTEM_BUSY.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] ShadowySpirits commented on issue #5838: Client will not retry to send message when broker busy

Posted by GitBox <gi...@apache.org>.
ShadowySpirits commented on issue #5838:
URL: https://github.com/apache/rocketmq/issues/5838#issuecomment-1375049018

   > In most case, when broker return SYSTEM_BUSY error code ,means brokers can't process more request,so sdk can't retry. if send order message,the more complex, sdk can't simple retry
   
   It is unlikely that all brokers are busy, so retrying to other nodes makes sense. Besides, retrying on TOPIC_NOT_EXIST seems meaningless.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] francisoliverlee commented on issue #5838: Client will not retry to send message when broker busy

Posted by GitBox <gi...@apache.org>.
francisoliverlee commented on issue #5838:
URL: https://github.com/apache/rocketmq/issues/5838#issuecomment-1375041469

   > IMO,SYSTEM_BUSY only meas current broker can't process so many requests, but other broker is ok. If it will retry in this case, the client will not fail to send and users will not see this error. @fuyou001
   
   顺序消息目前是分区顺序,也就是在相同queue里面的消息可以保证顺序。当重试到其他broker的时候,queue变化了,如何保证消息的顺序性就是一个问题。目前sdk里面是如何处理这种场景的呢, 我没有找到相关的code, 老哥可以发一下哇?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] cserwen commented on issue #5838: Client will not retry to send message when broker busy

Posted by GitBox <gi...@apache.org>.
cserwen commented on issue #5838:
URL: https://github.com/apache/rocketmq/issues/5838#issuecomment-1375042996

   顺序消息根本就不会重试呀,和普通发送使用的方法不一样,顺序消息调用`sendSelectImpl`,这里面没有重试逻辑,我这里说的只是针对普通消息的发送重试,包含重试逻辑的代码处于`sendDefaultImpl`方法。 @francisoliverlee 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Client will not retry to send message when broker busy [rocketmq]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #5838:
URL: https://github.com/apache/rocketmq/issues/5838#issuecomment-1890801346

   This issue was closed because it has been inactive for 3 days since being marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Client will not retry to send message when broker busy [rocketmq]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #5838: Client will not retry to send message when broker busy
URL: https://github.com/apache/rocketmq/issues/5838


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org