You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/27 19:02:27 UTC

[GitHub] [arrow] nealrichardson commented on a change in pull request #8069: ARROW-9867: [C++][Dataset] Add FileSystemDataset::filesystem property

nealrichardson commented on a change in pull request #8069:
URL: https://github.com/apache/arrow/pull/8069#discussion_r478630774



##########
File path: cpp/src/arrow/dataset/file_base.h
##########
@@ -195,15 +195,15 @@ class ARROW_DS_EXPORT FileSystemDataset : public Dataset {
   /// \param[in] schema the schema of the dataset
   /// \param[in] root_partition the partition expression of the dataset
   /// \param[in] format the format of each FileFragment.
-  /// \param[in] fragments list of fragments to create the dataset from
+  /// \param[in] fragments list of fragments to create the dataset from.
   ///
-  /// Note that all fragment must be of `FileFragment` type. The type are
-  /// erased to simplify callers.
+  /// Note that fragments wrapping files resident in a differing filesystems is not

Review comment:
       ```suggestion
     /// Note that fragments wrapping files resident in a differing filesystems are not
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org