You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/03/01 03:45:16 UTC
[GitHub] [rocketmq] skyline1688 opened a new pull request #2700: enhanced code on some minor issues
skyline1688 opened a new pull request #2700:
URL: https://github.com/apache/rocketmq/pull/2700
**Make sure set the target branch to `develop`**
## What is the purpose of the change
Did some enhancement on code in order to make it more suitable for reading
## Brief changelog
1: removed some code lines which are not needed anymore
2: added some default code in switch - case block since seems lack of it
3: added some @Override code line before implementation function due to lack of it, reduce confusion
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] vongosling closed pull request #2700: enhanced code on some minor issues
Posted by GitBox <gi...@apache.org>.
vongosling closed pull request #2700:
URL: https://github.com/apache/rocketmq/pull/2700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2700: enhanced code on some minor issues
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2700:
URL: https://github.com/apache/rocketmq/pull/2700#issuecomment-787623062
[](https://coveralls.io/builds/37519073)
Coverage increased (+0.01%) to 51.872% when pulling **a4ef142163fc505cb1b128b707a3f8a9fa1dc713 on skyline1688:some-code-enhancement** into **39bb9386f10d5d8dfe81183c172a3a86f6d313bd on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org