You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by ep...@apache.org on 2003/08/24 21:40:35 UTC
cvs commit: jakarta-turbine-fulcrum/security/src/java/org/apache/fulcrum/security/model/simple/entity SimplePermission.java SimpleRole.java
epugh 2003/08/24 12:40:35
Modified: security/src/java/org/apache/fulcrum/security/model/simple/entity
SimplePermission.java SimpleRole.java
Log:
Need model objects to actually glue the objects into the Simple model
Revision Changes Path
1.2 +0 -1 jakarta-turbine-fulcrum/security/src/java/org/apache/fulcrum/security/model/simple/entity/SimplePermission.java
Index: SimplePermission.java
===================================================================
RCS file: /home/cvs/jakarta-turbine-fulcrum/security/src/java/org/apache/fulcrum/security/model/simple/entity/SimplePermission.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- SimplePermission.java 23 Aug 2003 15:26:55 -0000 1.1
+++ SimplePermission.java 24 Aug 2003 19:40:35 -0000 1.2
@@ -12,5 +12,4 @@
public class SimplePermission extends SecurityEntityImpl implements Permission
{
-
}
1.2 +10 -5 jakarta-turbine-fulcrum/security/src/java/org/apache/fulcrum/security/model/simple/entity/SimpleRole.java
Index: SimpleRole.java
===================================================================
RCS file: /home/cvs/jakarta-turbine-fulcrum/security/src/java/org/apache/fulcrum/security/model/simple/entity/SimpleRole.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- SimpleRole.java 23 Aug 2003 15:26:55 -0000 1.1
+++ SimpleRole.java 24 Aug 2003 19:40:35 -0000 1.2
@@ -1,4 +1,3 @@
-
package org.apache.fulcrum.security.model.simple.entity;
import org.apache.fulcrum.security.entity.Permission;
import org.apache.fulcrum.security.entity.Role;
@@ -13,7 +12,7 @@
*/
public class SimpleRole extends SecurityEntityImpl implements Role
{
- private PermissionSet permissionSet = new PermissionSet();
+ private PermissionSet permissionSet = new PermissionSet();
/**
* @return
*/
@@ -21,7 +20,6 @@
{
return permissionSet;
}
-
/**
* @param permissionSet
*/
@@ -29,14 +27,21 @@
{
this.permissionSet = permissionSet;
}
-
+
+ /**
+ * This method should only be used by a RoleManager. Not directly.
+ * @param permission
+ */
public void addPermission(Permission permission)
{
getPermissions().add(permission);
}
+ /**
+ * This method should only be used by a RoleManager. Not directly.
+ * @param permission
+ */
public void removePermission(Permission permission)
{
getPermissions().remove(permission);
}
-
}
Re: cvs commit: jakarta-turbine-fulcrum/security/src/java/org/apache/fulcrum/security/model/simple/entity SimplePermission.java SimpleRole.java
Posted by "Henning P. Schmiedehausen" <hp...@intermeta.de>.
epugh@apache.org writes:
IMHO you're heading full speed in the wrong direction. Can you show us
some class diagrams / design why you're adding yet another Role
extension? What is the security.model.simple.entity? Is this just
repackaged o.a.fulcrum.security.entity ? Why do you need new glue
interfaces?
This all looks quite hackerish to me, sorry.
Regards
Henning
>epugh 2003/08/24 12:40:35
> Modified: security/src/java/org/apache/fulcrum/security/model/simple/entity
> SimplePermission.java SimpleRole.java
> Log:
> Need model objects to actually glue the objects into the Simple model
>
> Revision Changes Path
> 1.2 +0 -1 jakarta-turbine-fulcrum/security/src/java/org/apache/fulcrum/security/model/simple/entity/SimplePermission.java
>
> Index: SimplePermission.java
> ===================================================================
> RCS file: /home/cvs/jakarta-turbine-fulcrum/security/src/java/org/apache/fulcrum/security/model/simple/entity/SimplePermission.java,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -u -r1.1 -r1.2
> --- SimplePermission.java 23 Aug 2003 15:26:55 -0000 1.1
> +++ SimplePermission.java 24 Aug 2003 19:40:35 -0000 1.2
> @@ -12,5 +12,4 @@
> public class SimplePermission extends SecurityEntityImpl implements Permission
> {
>
> -
> }
>
>
>
> 1.2 +10 -5 jakarta-turbine-fulcrum/security/src/java/org/apache/fulcrum/security/model/simple/entity/SimpleRole.java
>
> Index: SimpleRole.java
> ===================================================================
> RCS file: /home/cvs/jakarta-turbine-fulcrum/security/src/java/org/apache/fulcrum/security/model/simple/entity/SimpleRole.java,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -u -r1.1 -r1.2
> --- SimpleRole.java 23 Aug 2003 15:26:55 -0000 1.1
> +++ SimpleRole.java 24 Aug 2003 19:40:35 -0000 1.2
> @@ -1,4 +1,3 @@
> -
> package org.apache.fulcrum.security.model.simple.entity;
> import org.apache.fulcrum.security.entity.Permission;
> import org.apache.fulcrum.security.entity.Role;
> @@ -13,7 +12,7 @@
> */
> public class SimpleRole extends SecurityEntityImpl implements Role
> {
> - private PermissionSet permissionSet = new PermissionSet();
> + private PermissionSet permissionSet = new PermissionSet();
> /**
> * @return
> */
> @@ -21,7 +20,6 @@
> {
> return permissionSet;
> }
> -
> /**
> * @param permissionSet
> */
> @@ -29,14 +27,21 @@
> {
> this.permissionSet = permissionSet;
> }
> -
> +
> + /**
> + * This method should only be used by a RoleManager. Not directly.
> + * @param permission
> + */
> public void addPermission(Permission permission)
> {
> getPermissions().add(permission);
> }
> + /**
> + * This method should only be used by a RoleManager. Not directly.
> + * @param permission
> + */
> public void removePermission(Permission permission)
> {
> getPermissions().remove(permission);
> }
> -
> }
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
hps@intermeta.de +49 9131 50 654 0 http://www.intermeta.de/
Java, perl, Solaris, Linux, xSP Consulting, Web Services
freelance consultant -- Jakarta Turbine Development -- hero for hire
"Dominate!! Dominate!! Eat your young and aggregate! I have grotty silicon!"
-- AOL CD when played backwards (User Friendly - 200-10-15)