You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/01/12 15:54:55 UTC

[GitHub] [iotdb] xinzhongtianxia opened a new pull request #4792: Feature/kubernetes helm

xinzhongtianxia opened a new pull request #4792:
URL: https://github.com/apache/iotdb/pull/4792


   I submit a PR to support deploying iotdb both standalone and cluster on kubernetes with helm.
   1. It is not a k8s operator, and does not support scale out. In the future, an operator is needed, probably after the completion of the new cluster architecture. For now, helm is enough.
   2. In k8s, a pod's ip will change after restarting, so we should use pod's FQDN as seed_nodes. So I removed the logical of replacing hostname with ip when starting iotdb-cluster.
   3. Added EN/ZH docs for iotdb-on-kubernetes
   
   jira: https://issues.apache.org/jira/browse/IOTDB-2329


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #4792: [IOTDB-2329] Deploy IoTDB on Kubernetes with Helm

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4792:
URL: https://github.com/apache/iotdb/pull/4792#issuecomment-1011950279


   
   [![Coverage Status](https://coveralls.io/builds/45703412/badge)](https://coveralls.io/builds/45703412)
   
   Coverage increased (+0.02%) to 67.809% when pulling **f1e7d3e7b0323b9808a9e92326a2e455060d6c15 on xinzhongtianxia:feature/kubernetes_helm** into **2659d1c1cae29247460ccb28e631d7ec12959cc9 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #4792: [IOTDB-2329] Deploy IoTDB on Kubernetes with Helm

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4792:
URL: https://github.com/apache/iotdb/pull/4792#issuecomment-1011950279


   
   [![Coverage Status](https://coveralls.io/builds/45856458/badge)](https://coveralls.io/builds/45856458)
   
   Coverage increased (+0.02%) to 67.744% when pulling **ba5e644f1515753a2305274a9d038d40d4394d2d on xinzhongtianxia:feature/kubernetes_helm** into **f9011617315ac9a7e2516597eb773b102f0d84d7 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] xinzhongtianxia commented on pull request #4792: [IOTDB-2329] Deploy IoTDB on Kubernetes with Helm

Posted by GitBox <gi...@apache.org>.
xinzhongtianxia commented on pull request #4792:
URL: https://github.com/apache/iotdb/pull/4792#issuecomment-1015087165


   > Hi, it is better to copy "iotdb-engine.properties" and "iotdb-cluster.properties" files to kubernetes/helm/cluster/conf in maven's generate-resources phase, rather than upload duplicated files directly.
   > 
   > Example codes: see client-py/pom.xml
   
   Done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #4792: [IOTDB-2329] Deploy IoTDB on Kubernetes with Helm

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4792:
URL: https://github.com/apache/iotdb/pull/4792#issuecomment-1011950279


   
   [![Coverage Status](https://coveralls.io/builds/46871046/badge)](https://coveralls.io/builds/46871046)
   
   Coverage increased (+0.09%) to 67.809% when pulling **36b64d5df1a348a589250b4a3d1a88162d22293a on xinzhongtianxia:feature/kubernetes_helm** into **f9011617315ac9a7e2516597eb773b102f0d84d7 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #4792: [IOTDB-2329] Deploy IoTDB on Kubernetes with Helm

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4792:
URL: https://github.com/apache/iotdb/pull/4792#issuecomment-1011950279


   
   [![Coverage Status](https://coveralls.io/builds/45856170/badge)](https://coveralls.io/builds/45856170)
   
   Coverage increased (+0.02%) to 67.737% when pulling **106bba6b456047d304a80e815c0f570ab7980feb on xinzhongtianxia:feature/kubernetes_helm** into **f9011617315ac9a7e2516597eb773b102f0d84d7 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls commented on pull request #4792: [IOTDB-2329] Deploy IoTDB on Kubernetes with Helm

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4792:
URL: https://github.com/apache/iotdb/pull/4792#issuecomment-1011950279


   
   [![Coverage Status](https://coveralls.io/builds/45592572/badge)](https://coveralls.io/builds/45592572)
   
   Coverage increased (+0.08%) to 67.964% when pulling **96980ba420875793e326c1cd7c950621336b7e85 on xinzhongtianxia:feature/kubernetes_helm** into **a4f5b0e8702f826759a9aa738a9e65a600f2d9b5 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] jixuan1989 removed a comment on pull request #4792: [IOTDB-2329] Deploy IoTDB on Kubernetes with Helm

Posted by GitBox <gi...@apache.org>.
jixuan1989 removed a comment on pull request #4792:
URL: https://github.com/apache/iotdb/pull/4792#issuecomment-1014602560


   Hi, it is better to copy  "iotdb-engine.properties" and "iotdb-cluster.properties" files to `kubernetes/helm/cluster/conf` in maven's `generate-resources` phase, rather than upload duplicated files directly.
   
   Example codes: see `client-py/pom.xml`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] jixuan1989 commented on pull request #4792: [IOTDB-2329] Deploy IoTDB on Kubernetes with Helm

Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #4792:
URL: https://github.com/apache/iotdb/pull/4792#issuecomment-1014602560


   Hi, it is better to copy  "iotdb-engine.properties" and "iotdb-cluster.properties" files to `kubernetes/helm/cluster/conf` in maven's `generate-resources` phase, rather than upload duplicated files directly.
   
   Example codes: see `client-py/pom.xml`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #4792: [IOTDB-2329] Deploy IoTDB on Kubernetes with Helm

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4792:
URL: https://github.com/apache/iotdb/pull/4792#issuecomment-1011950279


   
   [![Coverage Status](https://coveralls.io/builds/45702632/badge)](https://coveralls.io/builds/45702632)
   
   Coverage increased (+0.02%) to 67.811% when pulling **f1e7d3e7b0323b9808a9e92326a2e455060d6c15 on xinzhongtianxia:feature/kubernetes_helm** into **2659d1c1cae29247460ccb28e631d7ec12959cc9 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #4792: [IOTDB-2329] Deploy IoTDB on Kubernetes with Helm

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4792:
URL: https://github.com/apache/iotdb/pull/4792#issuecomment-1011950279


   
   [![Coverage Status](https://coveralls.io/builds/45956596/badge)](https://coveralls.io/builds/45956596)
   
   Coverage decreased (-0.01%) to 67.709% when pulling **86b0aab0e08879350fd71eefad307edddabb6898 on xinzhongtianxia:feature/kubernetes_helm** into **f9011617315ac9a7e2516597eb773b102f0d84d7 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] xinzhongtianxia closed pull request #4792: [IOTDB-2329] Deploy IoTDB on Kubernetes with Helm

Posted by GitBox <gi...@apache.org>.
xinzhongtianxia closed pull request #4792:
URL: https://github.com/apache/iotdb/pull/4792


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org