You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/14 06:26:52 UTC

[GitHub] [hudi] minihippo opened a new pull request #4806: [HUDI-3419] Load class through reflection in a thread-safe way.

minihippo opened a new pull request #4806:
URL: https://github.com/apache/hudi/pull/4806


   ## What is the purpose of the pull request
   
   *Fix the NPE bug when load class by reflection*
   ![Uploading image.png…]()
   
   ## Brief change log
   
     - *Change the ReflectionUtils*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #4806: [HUDI-3419] Load class through reflection in a thread-safe way.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4806:
URL: https://github.com/apache/hudi/pull/4806#issuecomment-1038700305


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9d18a410375b41d5605117f82e5bae089ac36f52",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9d18a410375b41d5605117f82e5bae089ac36f52",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9d18a410375b41d5605117f82e5bae089ac36f52 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #4806: [HUDI-3419] Load class through reflection in a thread-safe way.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4806:
URL: https://github.com/apache/hudi/pull/4806#issuecomment-1038702477


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9d18a410375b41d5605117f82e5bae089ac36f52",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5973",
       "triggerID" : "9d18a410375b41d5605117f82e5bae089ac36f52",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9d18a410375b41d5605117f82e5bae089ac36f52 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5973) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 commented on a change in pull request #4806: [HUDI-3419] Load class through reflection in a thread-safe way.

Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #4806:
URL: https://github.com/apache/hudi/pull/4806#discussion_r805621560



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/ReflectionUtils.java
##########
@@ -45,7 +45,7 @@
 
   private static final Logger LOG = LogManager.getLogger(ReflectionUtils.class);
 
-  private static final Map<String, Class<?>> CLAZZ_CACHE = new HashMap<>();
+  private static final Map<String, Class<?>> CLAZZ_CACHE = new ConcurrentHashMap<>();

Review comment:
       Thanks, can you explain why it is not thread-safe now, we already add a synchronized lock on the cache `CLAZZ_CACHE`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4806: [HUDI-3419] Load class through reflection in a thread-safe way.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4806:
URL: https://github.com/apache/hudi/pull/4806#issuecomment-1038746713


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9d18a410375b41d5605117f82e5bae089ac36f52",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5973",
       "triggerID" : "9d18a410375b41d5605117f82e5bae089ac36f52",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9d18a410375b41d5605117f82e5bae089ac36f52 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5973) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4806: [HUDI-3419] Load class through reflection in a thread-safe way.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4806:
URL: https://github.com/apache/hudi/pull/4806#issuecomment-1038700305


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9d18a410375b41d5605117f82e5bae089ac36f52",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9d18a410375b41d5605117f82e5bae089ac36f52",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9d18a410375b41d5605117f82e5bae089ac36f52 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4806: [HUDI-3419] Load class through reflection in a thread-safe way.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4806:
URL: https://github.com/apache/hudi/pull/4806#issuecomment-1038702477


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9d18a410375b41d5605117f82e5bae089ac36f52",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5973",
       "triggerID" : "9d18a410375b41d5605117f82e5bae089ac36f52",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9d18a410375b41d5605117f82e5bae089ac36f52 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5973) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] minihippo closed pull request #4806: [HUDI-3419] Load class through reflection in a thread-safe way.

Posted by GitBox <gi...@apache.org>.
minihippo closed pull request #4806:
URL: https://github.com/apache/hudi/pull/4806


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org